Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #810

wants to merge 1 commit into from

Conversation

valentin19939
Copy link

No description provided.

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 12, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the server functionality! 🎉 Your code meets the task requirements and constraints effectively. Just a small suggestion: consider adding a check to ensure toCase is not null before calling toUpperCase(). This will help prevent any potential runtime errors. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/createServer.js

const validationErrors = validateRequest(
text,
toCase ? toCase.toUpperCase() : null,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure toCase is not null before calling toUpperCase(). You can add a check to handle cases where toCase is not provided, to prevent potential runtime errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentin19939 @mateacademy-ai-mentor