Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #806

wants to merge 1 commit into from

Conversation

ab3MN
Copy link

@ab3MN ab3MN commented Dec 3, 2024

Solution

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the solution! 🎉 The core functionality is working well, and the code meets the task requirements. There are just a couple of minor issues to address: correcting the import path for sendJSONResponse and ensuring the convertErrorMessage format is URL-friendly. These are small tweaks and don't impact the overall functionality. Keep up the excellent work, and consider these improvements for future projects! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

class ErrorCase {
caseTypes = ['SNAKE', 'KEBAB', 'CAMEL', 'PASCAL', 'UPPER'];

convertErrorMessage = '/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convertErrorMessage string uses a placeholder format that might not be correctly interpreted if used directly in a URL. Consider using a more explicit format or providing an example of how the URL should be structured.


const { convertToCase } = require('./convertToCase/convertToCase');
const { errorCase } = require('./Error');
const { sendJSONResponse } = require('./senResponse');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the import path for sendJSONResponse. It should be ./sendResponse instead of ./senResponse to match the file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants