Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stars box #5361

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add stars box #5361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3da0dd6
add stars box
lucasschumann Feb 2, 2025
07d2c1b
fix star box
lucasschumann Feb 2, 2025
de8e4b1
fix stars box
lucasschumann Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Implement the [Stars Block](https://www.figma.com/file/ojkArVazq7vsX0nbpn9CxZ/Moyo-%2F-Catalog-(ENG)?node-id=11325%3A2960) used in a card and catalog.

Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.
Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.

> Here are the [Layout Tasks Instructions](https://mate-academy.github.io/layout_task-guideline)

Expand All @@ -22,8 +22,8 @@ Hold `Alt` key (`Option` on MacOS) to measure distances in Figma.

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_stars/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_stars/report/html_report/)
- [DEMO LINK](https://lucasschumann.github.io/layout_stars/)
- [TEST REPORT LINK](https://lucasschumann.github.io/layout_stars/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
49 changes: 49 additions & 0 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,54 @@
</head>
<body>
<h1>Stars</h1>
<div class="container">
<div class="stars stars--0">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--1">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--2">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--3">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--4">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>

<div class="stars stars--5">
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
<span class="stars__star"></span>
</div>
</div>
Comment on lines +17 to +65
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires using pseudo-selectors to activate the first N stars, but the current implementation does not follow this requirement. Consider using CSS pseudo-selectors to manage the active state of the stars.

</body>
</html>
36 changes: 36 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,37 @@
/* add styles here */
html {
margin: 0;
background-color: gray;
}

.container {
width: 96px;
height: 116px;
background-color: black;
}
Comment on lines +6 to +10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each BEM block should have its own file according to the task requirements. Consider separating the styles for different blocks into individual files for better maintainability.



.stars {
display: flex;
}

.stars__star {
background-image: url(images/star.svg);
background-position: center;
background-repeat: no-repeat;
background-size: contain;
width:16px;
height: 16px;
margin: 2px;
}

.stars--1 {
position: absolute;
background-image: url(images/star-active.svg);
background-position: center;
background-repeat: 200%;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background-repeat property value 200% is incorrect. Valid values are repeat, repeat-x, repeat-y, no-repeat, space, or round. Consider using one of these values to achieve the desired effect.

background-size: contain;
width: 16px;
height: 16px;
margin: 2px;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .stars--1 class is styled with position: absolute;, but there is no context or parent element with position: relative; or similar to contain it. This may lead to unexpected positioning. Ensure that the parent element is styled appropriately to contain absolutely positioned children.

Loading