add task solution #5309
add task solution #5309
Conversation
There was a problem hiding this comment.
Great job on your implementation! 🎉 You've met most of the task requirements, and your code is functional. Just a couple of things to keep in mind: ensure the <html> tag is correctly formatted, and consider refining your CSS selectors for more precise styling. Keep up the great work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,5 +1,8 @@ | |||
| <!doctype html> | |||
| <html lang="en"> | |||
| <html | |||
There was a problem hiding this comment.
The <html> tag is incorrectly self-closed. In HTML, the <html> tag should not be self-closing. It should be <html lang="en" class="page">.
| .stars--1 :first-child, | ||
| .stars--2 :nth-child(-n + 2), | ||
| .stars--3 :nth-child(-n + 3), | ||
| .stars--4 :nth-child(-n + 4), | ||
| .stars--5 :nth-child(-n + 5) { |
There was a problem hiding this comment.
The selectors .stars--n :first-child and similar use a descendant combinator (space) which means any first child within .stars--n, not necessarily a direct child. If you intend to style only direct children, consider using the child combinator (>) instead, like .stars--1 > :first-child.
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️