Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dmytro-selikhov
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation is almost there! 🎉 However, there are a couple of critical issues that need to be addressed before we can approve the pull request:

  1. Use of Extra Classes: The task specifies that no extra classes should be added to the elements for indicating active stars. Instead, a container modifier and a pseudo-selector should be used. Please adjust your implementation to comply with this requirement.

  2. File Structure: Each BEM block should have its own separate file. Currently, all styles are in a single style.css file. Please refactor your code to separate the BEM blocks into individual files.

Once these issues are resolved, your solution will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on organizing the HTML structure using the BEM methodology! 🎉 However, there are a few areas that need improvement:

  1. Use of Extra Classes: You've made progress by using pseudo-selectors for active stars, but ensure to avoid using extra classes like stars--0, stars--1, etc. Stick to the task requirement of using a container modifier and a pseudo-selector.

  2. File Structure: Currently, all styles are in a single style.css file. To fully comply with the task requirements, refactor your code to separate each BEM block into individual files.

These adjustments will not only align your work with the task requirements but also enhance the maintainability of your code. Keep up the good work, and remember to address these points in future projects to avoid similar issues. Your effort is commendable, and these improvements will help you grow as a developer. Keep learning and improving! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -13,6 +13,52 @@
/>
</head>
<body>
<h1>Stars</h1>
<div class="stars stars--0">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of stars--0 as an extra class to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

<div class="stars__star"></div>
</div>

<div class="stars stars--1">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of stars--1 as an extra class to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

<div class="stars__star"></div>
</div>

<div class="stars stars--2">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of stars--2 as an extra class to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

<div class="stars__star"></div>
</div>

<div class="stars stars--3">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of stars--3 as an extra class to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

<div class="stars__star"></div>
</div>

<div class="stars stars--4">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of stars--4 as an extra class to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

margin-right: 0;
} */

.stars--1 .stars__star:nth-child(-n + 1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of .stars--1 to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

background-image: url('./images/star-active.svg');
}

.stars--2 .stars__star:nth-child(-n + 2) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of .stars--2 to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

background-image: url('./images/star-active.svg');
}

.stars--3 .stars__star:nth-child(-n + 3) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of .stars--3 to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

background-image: url('./images/star-active.svg');
}

.stars--4 .stars__star:nth-child(-n + 4) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of .stars--4 to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

background-image: url('./images/star-active.svg');
}

.stars--5 .stars__star:nth-child(-n + 5) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of .stars--5 to indicate active stars is against the task requirements. Consider using a container modifier and a pseudo-selector instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants