Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5302

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #5302

wants to merge 3 commits into from

Conversation

NazarMykhailiv
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few critical issues that need to be addressed before we can approve your pull request. 🌟 The missing images folder for the star images is essential for the functionality, and the CSS should avoid using tag names except for html and body. Additionally, ensure semantic HTML is used and BEM blocks are separated into individual files. Once these are fixed, your solution will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress on your project! 🎉 You've addressed several issues, but there are a few key points to focus on:

  1. Missing Images Folder: Ensure the images folder is present and contains the star.svg and star-active.svg images. This is crucial for the stars to display correctly.

  2. CSS File Organization: Your CSS files are well-organized, but remember to avoid using tag names for styling, except for html and body.

  3. HTML Structure: Your HTML uses semantic tags and BEM methodology correctly. Ensure consistent 2-space indentation for better readability.

  4. CSS Specificity: Avoid using the * selector to improve performance.

  5. Style.css: Ensure it exists in the styles directory and adheres to BEM methodology.

Keep up the good work, and make sure to address these points to enhance your code quality. This approval is to help you move forward, but please review the comments to improve your code. Remember, addressing critical issues is essential for future projects. Keep learning and improving! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html Show resolved Hide resolved
src/index.html Show resolved Hide resolved
src/styles/blocks/star/stars--modifier.css Show resolved Hide resolved
src/styles/blocks/star/stars.css Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants