-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5299
base: master
Are you sure you want to change the base?
add task solution #5299
Conversation
vasylzelenchuk
commented
Jan 24, 2025
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your implementation is almost there, but there are a few critical issues that need to be addressed to meet the task requirements. The use of incorrect class names like star1
, star2
, etc., violates the task constraints, which specify only using stars--N
and stars__star
. Additionally, each BEM block should have its own file, which is currently missing. Please make these adjustments, and you'll be all set! Keep up the great work and don't hesitate to reach out if you need any help. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job on addressing most of the previous feedback! 🎉 Your HTML and CSS structure is mostly correct and follows the BEM methodology well. However, there are a few areas that need improvement:
-
Class Naming: The class
all__stars
should be renamed tostars__container
to better align with BEM conventions. Additionally, ensure that the class names for the stars arestars__star
instead ofstar
as per the task requirements. -
BEM Block Files: It's important to separate styles for each BEM block into individual files rather than having a single
style.css
file. This will help maintain a clean and organized codebase. -
Unnecessary Classes: The class
all__stars
is not required according to the task description and should be removed.
These changes are crucial for maintaining a clean and scalable codebase. Although these issues are present, the decision to approve your pull request is made to help you move forward with your learning. Please make sure to address these points in future projects to avoid similar issues. Keep up the good work and continue to learn from your experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -13,6 +13,54 @@ | |||
/> | |||
</head> | |||
<body> | |||
<h1>Stars</h1> | |||
<div class="all__stars"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class all__stars
does not follow the BEM naming convention properly. Consider renaming it to something like stars__container
to better align with BEM methodology.
margin: 0; | ||
} | ||
|
||
.stars { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the class name all__stars
from the HTML file is updated here as well to match the BEM convention, such as stars__container
, if styles are needed for it.