Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #5295

wants to merge 2 commits into from

Conversation

Vadya2018
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission! Your code is almost there, but there are a few critical issues that need to be addressed before we can approve it:

  1. CSS Selector Usage: The CSS selectors for the active stars are not correctly implemented. The task requires using a container modifier with a pseudo-selector to add yellow stars, but the current implementation uses :nth-child selectors for each star, which is not aligned with the requirement to use pseudo-selectors. Additionally, there are unnecessary spaces in your CSS selectors (e.g., .stars--5 :nth-child(5)), which could lead to unintended specificity issues. Please remove these spaces to ensure correct styling.

  2. File Organization: The task requires each BEM block to have its own separate file. Currently, all styles are in a single CSS file, which does not meet this requirement. Please organize your files accordingly.

  3. HTML Structure: Ensure that the indentation follows the 2-space rule as specified in the checklist.

Once these issues are resolved, your code will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/style.css Outdated
margin-right: 4px;
}

.stars--1 :nth-child(1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--1 and :nth-child(1). This could lead to unintended specificity issues. It should be .stars--1:nth-child(1) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--2 :nth-child(1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--2 and :nth-child(1). It should be .stars--2:nth-child(1) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--3 :nth-child(1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--3 and :nth-child(1). It should be .stars--3:nth-child(1) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--4 :nth-child(1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--4 and :nth-child(1). It should be .stars--4:nth-child(1) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--5 :nth-child(1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--5 and :nth-child(1). It should be .stars--5:nth-child(1) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--4 :nth-child(3) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--4 and :nth-child(3). It should be .stars--4:nth-child(3) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--5 :nth-child(3) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--5 and :nth-child(3). It should be .stars--5:nth-child(3) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--4 :nth-child(4) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--4 and :nth-child(4). It should be .stars--4:nth-child(4) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--5 :nth-child(4) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--5 and :nth-child(4). It should be .stars--5:nth-child(4) without the space.

src/style.css Outdated
background-image: url(/src/images/star-active.svg);
}

.stars--5 :nth-child(5) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unnecessary space between .stars--5 and :nth-child(5). It should be .stars--5:nth-child(5) without the space.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission! 🎉 While your code has been approved to help you move forward with your learning journey, there are a few important areas for improvement:

  1. CSS Selector Usage: The current use of :nth-child selectors for styling active stars does not align with the task requirement to use a container modifier with a pseudo-selector. Please consider revising this to meet the task specifications.

  2. File Organization: Each BEM block should have its own separate file. Currently, all styles are consolidated into a single CSS file (style.css), which does not adhere to the task requirements.

  3. HTML Indentation: Ensure that the HTML file consistently follows the 2-space indentation rule as specified in the checklist. This will enhance the readability and maintainability of your code.

  4. Syntax Error: There is a syntax error in one of your CSS selectors (stars--:). Please correct this to ensure proper functionality.

Please address these issues in your future work to enhance the quality and functionality of your code. Keep up the great work and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +16 to +58
<div class="container">
<div class="stars stars--0">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--2">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--3">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--5">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the indentation follows the 2-space rule as specified in the checklist. Currently, the indentation is inconsistent, which can affect readability and maintainability of the code.

Comment on lines +24 to +26
.stars--1:nth-child(1) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :nth-child selectors here does not align with the task requirement to use a container modifier with a pseudo-selector to style active stars. Consider using a different approach that matches the task requirements.

Comment on lines +28 to +30
.stars--:nth-child(1) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax error in this selector. The class name stars--: is incomplete and likely a typo. Ensure that the class name is correctly specified.

Comment on lines +32 to +34
.stars--3:nth-child(1) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :nth-child selectors here does not align with the task requirement to use a container modifier with a pseudo-selector to style active stars. Consider using a different approach that matches the task requirements.

Comment on lines +36 to +38
.stars--4:nth-child(1) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :nth-child selectors here does not align with the task requirement to use a container modifier with a pseudo-selector to style active stars. Consider using a different approach that matches the task requirements.

Comment on lines +64 to +66
.stars--4:nth-child(3) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :nth-child selectors here does not align with the task requirement to use a container modifier with a pseudo-selector to style active stars. Consider using a different approach that matches the task requirements.

Comment on lines +68 to +70
.stars--5:nth-child(3) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :nth-child selectors here does not align with the task requirement to use a container modifier with a pseudo-selector to style active stars. Consider using a different approach that matches the task requirements.

Comment on lines +72 to +74
.stars--4:nth-child(4) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :nth-child selectors here does not align with the task requirement to use a container modifier with a pseudo-selector to style active stars. Consider using a different approach that matches the task requirements.

Comment on lines +76 to +78
.stars--5:nth-child(4) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :nth-child selectors here does not align with the task requirement to use a container modifier with a pseudo-selector to style active stars. Consider using a different approach that matches the task requirements.

Comment on lines +80 to +82
.stars--5:nth-child(5) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of :nth-child selectors here does not align with the task requirement to use a container modifier with a pseudo-selector to style active stars. Consider using a different approach that matches the task requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants