stars #5293
stars #5293
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:
-
HTML Structure: The
<html>tag is self-closing, which is incorrect and affects the overall structure of your HTML. Please ensure it is properly opened and closed. -
CSS Selector Issue: The selector
.stars--0 .stars__star:nth-child(-n + 0)is logically incorrect as it selects no elements. Consider revising it to target the intended elements correctly. -
File Structure and BEM Compliance: Each BEM block should have its own separate file. Currently, all styles are in a single
style.cssfile, which does not align with the task requirements.
These issues are critical as they impact the functionality and core requirements of the task. Once these are addressed, your solution will be much stronger. Keep up the great work, and don't hesitate to reach out if you need further assistance! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| @@ -1,5 +1,8 @@ | |||
| <!doctype html> | |||
| <html lang="en"> | |||
| <html | |||
There was a problem hiding this comment.
The <html> tag should not be self-closing. It should be written as <html lang="en" class="page"> without the self-closing slash.
src/style.css
Outdated
| margin-right: 4px; | ||
| } | ||
|
|
||
| .stars--0 .stars__star:nth-child(-n + 0) { |
There was a problem hiding this comment.
The selector .stars--0 .stars__star:nth-child(-n + 0) is incorrect because it selects no elements. Consider changing it to .stars--0 .stars__star:nth-child(1) if you want to apply styles to the first star.
There was a problem hiding this comment.
Great job on addressing the HTML structure and CSS selector issues! 🎉 The <html> tag is now correctly opened and closed, and the CSS selectors are targeting the intended elements as expected. However, please note that the task requires each BEM block to have its own separate file, which hasn't been met yet. It's important to separate the styles for each BEM block into individual files to comply with the task requirements. This will help you maintain a cleaner and more organized codebase. Keep up the good work, and make sure to review the comments to improve your code further. Remember, addressing these issues will enhance your skills and help you avoid similar problems in the future. Keep learning and improving! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️