Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5279

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add task solution #5279

wants to merge 3 commits into from

Conversation

Paulohsdev
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code has some critical issues that need to be addressed before it can be approved. The use of the universal selector * in CSS can impact performance, and the task requires display: flex instead of display: grid for the stars block. Additionally, the task specifies not to add extra classes or use the gap property, which your code currently does. Please make these adjustments to align with the task requirements. Keep up the good work, and I'm confident you'll nail it with these changes! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing most of the previous issues! 🎉 The stars component is now well-organized, and the use of display: flex aligns with the task requirements. However, there are a few points to consider for further improvement:

  1. CSS Universal Selector: The universal selector * is still present in the CSS file. This can impact performance, so it's best to apply styles directly to the necessary elements instead.

  2. Margin Usage: While you've avoided using the gap property, be cautious with using margin-right on .stars__star, as it might be seen as adding extra spacing. Ensure this aligns with the task constraints.

Overall, your solution is on the right track, and the decision to approve is to help you move forward with your learning. Please review the comments to refine your code further. Keep up the good work and continue improving! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


.stars__star {
background-position: center;
margin-right: 4px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of margin-right here might be considered as adding extra spacing between elements. The task specifies not to use the gap property or add extra classes, so ensure this approach is acceptable within the task constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants