Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5001

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #5001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af85f61
add task solution
Dariya-Goncharovskaya Jan 11, 2025
05a1eb8
add solution
Dariya-Goncharovskaya Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -33,8 +33,8 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs
## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://Dariya-Goncharovskaya.github.io/layout_catalog/)
- [TEST REPORT LINK](https://Dariya-Goncharovskaya.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
360 changes: 358 additions & 2 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,367 @@
/>
<link
rel="stylesheet"
href="styles/index.scss"
href="styles/main.scss"
/>
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<a
class="header__link"
href="index.html"
>
<img
src="images/logo.png"
alt="moyo__logo"
/>
</a>
<nav class="header__nav">
<ul class="header__nav-list">
<li class="header__nav-item">
<a
href="#"
class="header__nav-link is-active"
>
Apple
</a>
</li>
<li class="header__nav-item">
<a
href="#"
class="header__nav-link"
>
Samsung
</a>
</li>
<li class="header__nav-item">
<a
href="#"
class="header__nav-link"
>
Smartphones
</a>
</li>
<li class="header__nav-item">
<a
href="#"
class="header__nav-link"
data-qa="nav-hover"
>
Laptops & Computers
</a>
</li>
<li class="header__nav-item">
<a
href="#"
class="header__nav-link"
>
Gadgets
</a>
</li>
<li class="header__nav-item">
<a
href="#"
class="header__nav-link"
>
Tablets
</a>
</li>
<li class="header__nav-item">
<a
href="#"
class="header__nav-link"
>
Photo
</a>
</li>
<li class="header__nav-item">
<a
href="#"
class="header__nav-link"
>
Video
</a>
</li>
</ul>
</nav>
</header>
<main class="container">
<div
class="card"
data-qa="card"
>
<img
class="card__image"
src="./images/imac.jpeg"
alt="Product image"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<div class="card__product-code">Product code: 195434</div>
<div class="card__review"></div>
<div class="card__between">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="card__reviews">Reviews: 5</div>
</div>

<div class="card__price">
<span class="card__price-label">Price:</span>
<span class="card__price-value">$2,199</span>
</div>
<a
class="card__buy"
href="#"
data-qa="card-hover"
>
BUY
</a>
</div>
<div
class="card"
Comment on lines +143 to +144
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data-qa attribute is missing on this card. Ensure that each card has a unique data-qa attribute if required by the task.

>
<img
class="card__image"
src="./images/imac.jpeg"
alt="Product image"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<div class="card__product-code">Product code: 195434</div>
<div class="card__review"></div>
<div class="card__between">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="card__reviews">Reviews: 5</div>
</div>

<div class="card__price">
<span class="card__price-label">Price:</span>
<span class="card__price-value">$2,199</span>
</div>
<a
class="card__buy"
Comment on lines +171 to +172
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data-qa attribute is missing on the 'Buy' link inside this card. Ensure that the 'Buy' link inside the first card has the data-qa attribute as required.

href="#"
>
BUY
</a>
</div>
<div
class="card"
>
<img
class="card__image"
src="./images/imac.jpeg"
alt="Product image"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<div class="card__product-code">Product code: 195434</div>
<div class="card__review"></div>
<div class="card__between">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="card__reviews">Reviews: 5</div>
</div>
<div class="card__price">
<span class="card__price-label">Price:</span>
<span class="card__price-value">$2,199</span>
</div>
<a
class="card__buy"
href="#"
>
BUY
</a>
</div>
<div
class="card"
>
<img
class="card__image"
src="./images/imac.jpeg"
alt="Product image"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<div class="card__product-code">Product code: 195434</div>
<div class="card__review"></div>
<div class="card__between">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="card__reviews">Reviews: 5</div>
</div>
<div class="card__price">
<span class="card__price-label">Price:</span>
<span class="card__price-value">$2,199</span>
</div>
<a
class="card__buy"
href="#"
>
BUY
</a>
</div>
<div
class="card"
>
<img
class="card__image"
src="./images/imac.jpeg"
alt="Product image"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<div class="card__product-code">Product code: 195434</div>
<div class="card__review"></div>
<div class="card__between">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="card__reviews">Reviews: 5</div>
</div>
<div class="card__price">
<span class="card__price-label">Price:</span>
<span class="card__price-value">$2,199</span>
</div>
<a
class="card__buy"
href="#"
>
BUY
</a>
</div>
<div
class="card"
>
<img
class="card__image"
src="./images/imac.jpeg"
alt="Product image"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<div class="card__product-code">Product code: 195434</div>
<div class="card__review"></div>
<div class="card__between">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="card__reviews">Reviews: 5</div>
</div>
<div class="card__price">
<span class="card__price-label">Price:</span>
<span class="card__price-value">$2,199</span>
</div>
<a
class="card__buy"
>
BUY
</a>
</div>
<div
class="card"
>
<img
class="card__image"
src="./images/imac.jpeg"
alt="Product image"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<div class="card__product-code">Product code: 195434</div>
<div class="card__review"></div>
<div class="card__between">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="card__reviews">Reviews: 5</div>
</div>
<div class="card__price">
<span class="card__price-label">Price:</span>
<span class="card__price-value">$2,199</span>
</div>
<a
class="card__buy"
href="#"
>
BUY
</a>
</div>
<div
class="card"
>
<img
class="card__image"
src="./images/imac.jpeg"
alt="Product image"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<div class="card__product-code">Product code: 195434</div>
<div class="card__review"></div>
<div class="card__between">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<div class="card__reviews">Reviews: 5</div>
</div>
<div class="card__price">
<span class="card__price-label">Price:</span>
<span class="card__price-value">$2,199</span>
</div>
<a
class="card__buy"
href="#"
>
BUY
</a>
</div>
</main>
</body>
</html>
Loading
Loading