add task solution #4993
add task solution #4993
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 While there are a couple of minor improvements suggested, such as adjusting the hover effect on the card to prevent layout shifts and using a relative path for the logo link, these do not critically impact the functionality of your code. Keep up the good work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <a | ||
| href="http://mateacademy.com" |
There was a problem hiding this comment.
Consider using a relative path for the href attribute in the logo link instead of an absolute URL. This will make the link more maintainable and flexible, especially if the domain changes or if the project is moved to a different server.
| padding: 0 16px; | ||
| background-color: #fff; | ||
|
|
||
| @include hover(transform, scale(1.2)); |
There was a problem hiding this comment.
The hover effect scales the entire card, which might cause layout shifts and affect the user experience. Consider using a more subtle hover effect, such as changing the background color or adding a shadow, to avoid disrupting the layout.
DEMO LINK
TEST REPORT LINK
All components follow BEM and use SCSS
Repeated sizes and special colors are put to variables
Grid is used for the columns
Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
All changes on
:hoverare smoothCode follows all the Code Style Rules ❗️