Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #4984

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #4984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b5911
Solution
Pamcik Jan 8, 2025
f610ae3
Solution after review
Pamcik Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -33,14 +33,14 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs
## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
- [DEMO LINK](https://Pamcik.github.io/layout_catalog/)
- [TEST REPORT LINK](https://Pamcik.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

- [ ] All components follow BEM and use SCSS
- [ ] Repeated sizes and special colors are put to variables
- [ ] Grid is used for the columns
- [ ] Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
- [ ] All changes on `:hover` are smooth
- [ ] Code follows all the [Code Style Rules ❗️](https://mate-academy.github.io/layout_task-guideline/html-css-code-style-rules)
- [x] All components follow BEM and use SCSS
- [x] Repeated sizes and special colors are put to variables
- [x] Grid is used for the columns
- [x] Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
- [x] All changes on `:hover` are smooth
- [x] Code follows all the [Code Style Rules ❗️](https://mate-academy.github.io/layout_task-guideline/html-css-code-style-rules)
360 changes: 359 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,364 @@
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<div class="header__logo">
<a
href="https://s3-alpha-sig.figma.com/img/833f/9aab/47d660efd384318772b6b8040db831aa?Expires=1734912000&Key-Pair-Id=APKAQ4GOSFWCVNEHN3O4&Signature=dswIrz-CM71mAanXGvKRXPjecjfgsdMxLMX42Ga2sG0CuUJJq4Jy5x5rODTPEzbqmmsgmlLLJss2~eQyfosxdUyGRzIGLeAOMJ13tFeyrIB5YiQQRtx~9LeDXPrYCLGvDa4mViqCuhj-IPGhPDrlsLYG7kCfSvZ9UHMBqlZ8WDyj4zCQ3o-5AuD5tBRIqrPEmgqFO161Qu7yXjPjXvFbJM8Iu-4jf45HZy5io3OmyRZdOyfPL~Z0GkyPChoNWJax7ioZ9o6xNZu271LRecCkmoaeEBlFF~8dRZSJqXl0E9A4w2v6wXO6E8vkZioe9b8bl0wiOHVJQEDxCqzP5H9YYA__"
>
<img
src="./images/logo.png"
alt="logo Moyo"
/>
</a>
</div>
<nav class="header__nav">
<ul class="header__nav-list">
<li class="header__nav-item">
<a
href="index.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute for the navigation link is pointing to index.html, which is the same page. If this is intentional, it's fine, but if these links are supposed to navigate to different pages, ensure they are pointing to the correct URLs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, the links don't lead anywhere. Is it better to leave index.html or #?

class="header__nav-link is-active header__nav-link--color"
>
Apple
</a>
</li>
<li class="header__nav-item">
<a
href="index.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, ensure that the href attribute is pointing to the correct destination if this link is supposed to navigate to a different page.

class="header__nav-link"
>
Samsung
</a>
</li>
<li class="header__nav-item">
<a
href="index.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the href attribute is pointing to the correct destination if this link is supposed to navigate to a different page.

class="header__nav-link"
>
Smartphones
</a>
</li>
<li class="header__nav-item">
<a
href="index.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the href attribute is pointing to the correct destination if this link is supposed to navigate to a different page.

class="header__nav-link"
data-qa="nav-hover"
>
Laptops & Computers
</a>
</li>
<li class="header__nav-item">
<a
href="index.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the href attribute is pointing to the correct destination if this link is supposed to navigate to a different page.

class="header__nav-link"
>
Gadgets
</a>
</li>
<li class="header__nav-item">
<a
href="index.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the href attribute is pointing to the correct destination if this link is supposed to navigate to a different page.

class="header__nav-link"
>
Tablets
</a>
</li>
<li class="header__nav-item">
<a
href="index.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the href attribute is pointing to the correct destination if this link is supposed to navigate to a different page.

class="header__nav-link"
>
Photo
</a>
</li>
<li class="header__nav-item">
<a
href="index.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the href attribute is pointing to the correct destination if this link is supposed to navigate to a different page.

class="header__nav-link"
>
Video
</a>
</li>
</ul>
</nav>
</header>

<main class="catalog">
<div
class="card"
data-qa="card"
>
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27'' Retina"
class="card__image"
/>
<div class="card__content">
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>
<p class="card__code">Product code: 195434</p>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span class="card__reviews">Reviews: 5</span>
</div>
<div class="card__price">
Price:
<span class="card__price-value">$2,199</span>
</div>
<a
href="#"
Comment on lines +136 to +137
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which means it doesn't lead anywhere. If this is a placeholder, it's fine, but ensure to update it with a valid URL if needed.

class="card__button"
data-qa="card-hover"
>
BUY
</a>
</div>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27'' Retina"
class="card__image"
/>
<div class="card__content">
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>
<p class="card__code">Product code: 195434</p>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span class="card__reviews">Reviews: 5</span>
</div>
<div class="card__price">
Price:
<span class="card__price-value">$2,199</span>
</div>
<a
href="#"
Comment on lines +171 to +172
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which means it doesn't lead anywhere. If this is a placeholder, it's fine, but ensure to update it with a valid URL if needed.

class="card__button"
>
BUY
</a>
</div>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27'' Retina"
class="card__image"
/>
<div class="card__content">
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>
<p class="card__code">Product code: 195434</p>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span class="card__reviews">Reviews: 5</span>
</div>
<div class="card__price">
Price:
<span class="card__price-value">$2,199</span>
</div>
<a
href="#"
Comment on lines +205 to +206
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which means it doesn't lead anywhere. If this is a placeholder, it's fine, but ensure to update it with a valid URL if needed.

class="card__button"
>
BUY
</a>
</div>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27'' Retina"
class="card__image"
/>
<div class="card__content">
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>
<p class="card__code">Product code: 195434</p>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span class="card__reviews">Reviews: 5</span>
</div>
<div class="card__price">
Price:
<span class="card__price-value">$2,199</span>
</div>
<a
href="#"
Comment on lines +239 to +240
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which means it doesn't lead anywhere. If this is a placeholder, it's fine, but ensure to update it with a valid URL if needed.

class="card__button"
>
BUY
</a>
</div>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27'' Retina"
class="card__image"
/>
<div class="card__content">
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>
<p class="card__code">Product code: 195434</p>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span class="card__reviews">Reviews: 5</span>
</div>
<div class="card__price">
Price:
<span class="card__price-value">$2,199</span>
</div>
<a
href="#"
Comment on lines +273 to +274
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which means it doesn't lead anywhere. If this is a placeholder, it's fine, but ensure to update it with a valid URL if needed.

class="card__button"
>
BUY
</a>
</div>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27'' Retina"
class="card__image"
/>
<div class="card__content">
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>
<p class="card__code">Product code: 195434</p>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span class="card__reviews">Reviews: 5</span>
</div>
<div class="card__price">
Price:
<span class="card__price-value">$2,199</span>
</div>
<a
href="#"
Comment on lines +307 to +308
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which means it doesn't lead anywhere. If this is a placeholder, it's fine, but ensure to update it with a valid URL if needed.

class="card__button"
>
BUY
</a>
</div>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27'' Retina"
class="card__image"
/>
<div class="card__content">
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>
<p class="card__code">Product code: 195434</p>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span class="card__reviews">Reviews: 5</span>
</div>
<div class="card__price">
Price:
<span class="card__price-value">$2,199</span>
</div>
<a
href="#"
Comment on lines +341 to +342
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which means it doesn't lead anywhere. If this is a placeholder, it's fine, but ensure to update it with a valid URL if needed.

class="card__button"
>
BUY
</a>
</div>
</div>

<div class="card">
<img
src="./images/imac.jpeg"
alt="APPLE A1419 iMac 27'' Retina"
class="card__image"
/>
<div class="card__content">
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>
<p class="card__code">Product code: 195434</p>
<div class="card__rating">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span class="card__reviews">Reviews: 5</span>
</div>
<div class="card__price">
Price:
<span class="card__price-value">$2,199</span>
</div>
<a
href="#"
Comment on lines +375 to +376
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which means it doesn't lead anywhere. If this is a placeholder, it's fine, but ensure to update it with a valid URL if needed.

class="card__button"
>
BUY
</a>
</div>
</div>
Comment on lines +107 to +382
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product cards are repeated with identical content. If the intention is to display different products, consider using a dynamic approach to populate these cards with varying data. This will enhance maintainability and scalability.

</main>
</body>
</html>
Loading
Loading