-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4960
base: master
Are you sure you want to change the base?
add task solution #4960
Conversation
veneracode
commented
Dec 28, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this pull request! 😊 There are a few critical issues that need to be addressed before we can approve it:
-
Incorrect Property Usage: The
background-color
property is used incorrectly and should be replaced withborder: 1px solid #f3f3f3;
to ensure the styling is applied as intended. -
BEM Naming Convention: There's a typo in the class name
&_imagep
, which should be corrected to&__image
to maintain consistency with the BEM naming convention. -
Unnecessary CSS Property: The
margin-bottom: 0;
property in the stars component is unnecessary due to the horizontal layout. Consider removing it unless needed elsewhere.
Please make these changes to align with the task requirements and ensure the functionality is correct. Once these issues are resolved, we can proceed with approval. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
padding: 32px 16px 16px; | ||
box-sizing: border-box; | ||
border-radius: 5px; | ||
background-color: 1px solid #f3f3f3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The background-color
property is incorrectly used here. It should be border: 1px solid #f3f3f3;
to apply a border instead of a background color.
color: #616070; | ||
} | ||
|
||
&_imagep { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a typo in the class name &_imagep
. It should be &__image
to maintain consistency with the BEM naming convention used throughout the file.
} | ||
|
||
&__star:last-child { | ||
margin-bottom: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The margin-bottom: 0;
property is not necessary here since the stars are displayed in a horizontal flexbox layout. Consider removing this line unless vertical spacing is needed in a different context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 While there are a few areas that need improvement, such as correcting the class name card__imagep
to card__image
and replacing the background-color
property with border: 1px solid #f3f3f3;
, your code is mostly well-structured. Additionally, ensure that the word 'Rewiews' is corrected to 'Reviews' throughout your HTML file. These changes will enhance the code quality and maintain consistency with the BEM naming convention. Remember to address these issues in future projects to avoid similar problems. Keep up the good work and continue learning from these experiences! 💪
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
> | ||
<div> | ||
<img | ||
class="card__imagep" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name card__imagep
seems to be a typo. It should be card__image
to maintain consistency with the BEM naming convention.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="card__rewiews">Rewiews:5</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'Rewiews' is misspelled. It should be 'Reviews'.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="card__rewiews">Rewiews:5</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'Rewiews' is misspelled. It should be 'Reviews'.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="card__rewiews">Rewiews:5</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'Rewiews' is misspelled. It should be 'Reviews'.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="card__rewiews">Rewiews:5</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'Rewiews' is misspelled. It should be 'Reviews'.
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<div class="card__rewiews">Rewiews:5</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'Rewiews' is misspelled. It should be 'Reviews'.
padding: 32px 16px 16px; | ||
box-sizing: border-box; | ||
border-radius: 5px; | ||
background-color: 1px solid #f3f3f3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The background-color
property is incorrectly used here. It should be replaced with border: 1px solid #f3f3f3;
to ensure the styling is applied as intended.
color: #616070; | ||
} | ||
|
||
&_imagep { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name &_imagep
is incorrect. It should be &__image
to maintain consistency with the BEM naming convention.
} | ||
|
||
&__star:last-child { | ||
margin-bottom: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The margin-bottom: 0;
property is unnecessary here because the stars are laid out horizontally. Consider removing it to clean up the code.
body { | ||
margin: 0; | ||
font-family: Roboto, serif, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font-family
declaration includes both 'serif' and 'sans-serif', which are typically mutually exclusive. Consider specifying only one as a fallback to 'Roboto' for clarity.