-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #4910
Develop #4910
Conversation
olga-wukelan
commented
Dec 7, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
readme.md
src/index.html
src/index.scss
src/styles/card.scss
src/styles/header.scss
src/styles/index.scss
src/styles/main.scss
src/styles/navigation.scss
src/styles/stars.scss
src/styles/variables.scss
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
readme.md
src/index.html
src/index.scss
src/styles/card.scss
src/styles/header.scss
src/styles/index.scss
src/styles/main.scss
src/styles/navigation.scss
src/styles/stars.scss
src/styles/variables.scss
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
readme.md
src/index.html
src/index.scss
src/styles/card.scss
src/styles/header.scss
src/styles/index.scss
src/styles/main.scss
src/styles/navigation.scss
src/styles/stars.scss
src/styles/variables.scss
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
readme.md
src/index.html
src/index.scss
src/styles/card.scss
src/styles/header.scss
src/styles/index.scss
src/styles/main.scss
src/styles/navigation.scss
src/styles/stars.scss
src/styles/variables.scss
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
src/index.html
Outdated
</header> | ||
<!-- #endregion --> | ||
|
||
<div class="main"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be main tag (the reason part of the tests failed)
src/index.html
Outdated
</div> | ||
|
||
<div class="card__value"> | ||
<h1 class="card__price">Price:</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h1 is not a proper tag for all text - use p
instead
h1 is a title of the entire page
src/index.html
Outdated
src="../src/images/imac.jpeg" | ||
alt="imac" | ||
/> | ||
<h1 class="card__title"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h1 class="card__title"> | |
<h2 class="card__title"> |
h1 is a title of the entire page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> | ||
<img | ||
class="card__image" | ||
src="../src/images/imac.jpeg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/index.html
Outdated
src="../src/images/imac.jpeg" | ||
alt="imac" | ||
/> | ||
<h1 class="card__title"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.