Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4910

Closed
wants to merge 4 commits into from
Closed

Develop #4910

wants to merge 4 commits into from

Conversation

olga-wukelan
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]

Additional info:
Ignored files list:

  • readme.md
  • src/index.html
  • src/index.scss
  • src/styles/card.scss
  • src/styles/header.scss
  • src/styles/index.scss
  • src/styles/main.scss
  • src/styles/navigation.scss
  • src/styles/stars.scss
  • src/styles/variables.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]

Additional info:
Ignored files list:

  • readme.md
  • src/index.html
  • src/index.scss
  • src/styles/card.scss
  • src/styles/header.scss
  • src/styles/index.scss
  • src/styles/main.scss
  • src/styles/navigation.scss
  • src/styles/stars.scss
  • src/styles/variables.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]

Additional info:
Ignored files list:

  • readme.md
  • src/index.html
  • src/index.scss
  • src/styles/card.scss
  • src/styles/header.scss
  • src/styles/index.scss
  • src/styles/main.scss
  • src/styles/navigation.scss
  • src/styles/stars.scss
  • src/styles/variables.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]

Additional info:
Ignored files list:

  • readme.md
  • src/index.html
  • src/index.scss
  • src/styles/card.scss
  • src/styles/header.scss
  • src/styles/index.scss
  • src/styles/main.scss
  • src/styles/navigation.scss
  • src/styles/stars.scss
  • src/styles/variables.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

src/index.html Outdated
</header>
<!-- #endregion -->

<div class="main">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be main tag (the reason part of the tests failed)

src/index.html Outdated
</div>

<div class="card__value">
<h1 class="card__price">Price:</h1>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h1 is not a proper tag for all text - use p instead

h1 is a title of the entire page

src/index.html Outdated
src="../src/images/imac.jpeg"
alt="imac"
/>
<h1 class="card__title">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1 class="card__title">
<h2 class="card__title">

h1 is a title of the entire page

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/styles/card.scss Outdated Show resolved Hide resolved
src/styles/card.scss Outdated Show resolved Hide resolved
src/styles/card.scss Outdated Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
src/styles/header.scss Outdated Show resolved Hide resolved
src/styles/header.scss Outdated Show resolved Hide resolved
>
<img
class="card__image"
src="../src/images/imac.jpeg"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to fix it
image

src/index.html Outdated
src="../src/images/imac.jpeg"
alt="imac"
/>
<h1 class="card__title">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@olga-wukelan olga-wukelan closed this by deleting the head repository Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants