add #4907

Valbel93 · 2024-12-07T15:54:52Z

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
_{[CODE: 4]}

Additional info:
Ignored files list:

readme.md
src/index.html
src/styles/index.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
_{[CODE: 4]}

Additional info:
Ignored files list:

readme.md
src/index.html
src/styles/header.scss
src/styles/index.scss
src/styles/main.scss
src/styles/stars.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
_{[CODE: 4]}

Additional info:
Ignored files list:

readme.md
src/index.html
src/styles/header.scss
src/styles/index.scss
src/styles/main.scss
src/styles/stars.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
_{[CODE: 4]}

Additional info:
Ignored files list:

readme.md
src/index.html
src/styles/header.scss
src/styles/index.scss
src/styles/main.scss
src/styles/stars.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

anastasiiavorobiova

Great work! Almost done!

anastasiiavorobiova · 2024-12-08T14:18:14Z

src/index.html

+        <h2 class="card__title">
+          APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
+          <p class="card__code">Product code: 195434</p>
+        </h2>


Suggested change

<h2 class="card__title">

APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)

<p class="card__code">Product code: 195434</p>

</h2>

<h2 class="card__title">

APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)

</h2>

<p class="card__code">Product code: 195434</p>

Element p is not allowed as child of element h2

volodymyr-soltys97

Good job!
Let's improve your code
This part of the task is incomplete

volodymyr-soltys97 · 2024-12-09T07:38:03Z

src/index.html

+          <div class="stars__star"></div>
+          <div class="stars__star"></div>
+          <div class="stars__star"></div>
+          <div class="stars__reviews">Reviews: 5</div>


You need to use the semantic tag for text, fix it everywhere

Suggested change

<div class="stars__reviews">Reviews: 5</div>

<p class="stars__reviews">Reviews: 5</p>

volodymyr-soltys97 · 2024-12-09T07:38:24Z

src/index.html

+      </div>
+      <div


Add the blank line between the cards

Suggested change

</div>

<div

</div>

<div

volodymyr-soltys97 · 2024-12-09T07:39:03Z

src/styles/main.scss

+  &:hover {
+    transform: scale(1.5);
+  }


volodymyr-soltys97 · 2024-12-09T07:39:57Z

src/styles/main.scss

+  border-radius: 5px;
+  border: 1px solid #00acdc;
+  color: #fff;
+  background-color: #00acdc;


Create a variable for repeated colors and use it everywhere

src/styles/header.scss

etojeDenys · 2024-12-09T20:06:35Z

src/styles/header.scss

+:root {
+  --font-family: Roboto, sans-serif;
+  --color: #00acdc;
+  --main-accent: #060b35;
+  --secondary: #616070;
+  --white: #fff;
+  --blue-accent: #00acdc;
+  --gray-elements: #f3f3f3;
+  --yellow-stars: #ffde6a;
+}


use sass vars

підкажіть будь ласка, що саме тут не так????
прописано все за для виконання в коді в подальшому, в чому помилка? Ми берем данні з Figma, там окрім цього, іншої інформації немає, все бралось звідти, по шаблону, що саме не так???

Hi, you need to use SCSS variables instead of CSS variables

etojeDenys · 2024-12-09T20:06:46Z

src/styles/main.scss

+.card {
+  border: 1px solid var(--gray-elements);
+  border-radius: 5px;
+  width: 198px;
+  height: 406px;
+  background-color: var(--white);
+  justify-content: center;
+  transition-duration: 300ms;
+
+  &:hover {
+    transform: scale(1.2);
+  }
+}
+
+.card__img {
+  width: 160px;
+  height: 134px;
+  margin: 32px 19px 36px;
+}
+
+.card__title {
+  font-weight: 500;
+  font-size: 12px;


готово.

volodymyr-soltys97

Good job!
To improve:
Cards should shrink as smoothly as they grow.

volodymyr-soltys97 · 2024-12-10T08:23:35Z

src/index.html

+          Price:
+          <div class="card__price-value">$2,199</div>


You need to use semantic tag for text, you can use tag p here, fix it everywhere

volodymyr-soltys97 · 2024-12-10T08:24:17Z

src/styles/header.scss

+:root {
+  --font-family: Roboto, sans-serif;
+  --color: #00acdc;
+  --main-accent: #060b35;
+  --secondary: #616070;
+  --white: #fff;
+  --blue-accent: #00acdc;
+  --gray-elements: #f3f3f3;
+  --yellow-stars: #ffde6a;
+}


Hi, you need to use SCSS variables instead of CSS variables

volodymyr-soltys97 · 2024-12-10T08:24:32Z

src/styles/header.scss

+  margin: 0;
+}
+
+header {


Use class selector

Suggested change

header {

.header {

volodymyr-soltys97 · 2024-12-10T08:24:52Z

src/styles/header.scss

+}
+
+.is-active {
+  color: #00acdc;


Use a variable for this color

volodymyr-soltys97

Good job!
Don't forget to make deploy after your changes

add

0738bc0

mateacademy-ai-mentor reviewed Dec 7, 2024

View reviewed changes

Valbel93 added 2 commits December 7, 2024 18:18

add solution

9d7a07b

add blocks Stars/Haeder/Main

bb2c538

mateacademy-ai-mentor reviewed Dec 7, 2024

View reviewed changes

solution for 1024

0f9a95d

mateacademy-ai-mentor reviewed Dec 7, 2024

View reviewed changes

add 1200px/transform

a395018

mateacademy-ai-mentor reviewed Dec 7, 2024

View reviewed changes

add solution all

f1554dc

anastasiiavorobiova suggested changes Dec 8, 2024

View reviewed changes

add <p> class

8db8114

Valbel93 requested review from anastasiiavorobiova and mateacademy-ai-mentor December 8, 2024 14:56

volodymyr-soltys97 suggested changes Dec 9, 2024

View reviewed changes

Valbel93 added 3 commits December 9, 2024 16:28

add transform/transition

9801ab2

add blank

35e3b6d

add duration 300ms

ccfcc04

Valbel93 requested a review from volodymyr-soltys97 December 9, 2024 15:02

Valbel93 added 2 commits December 9, 2024 18:47

add size for reviews + <p>

85d7a58

SOLUTION

b2384d2

etojeDenys suggested changes Dec 9, 2024

View reviewed changes

rework on recommendation etojeDenys

03cfe83

Valbel93 requested a review from etojeDenys December 9, 2024 20:56

reworked &

e5249a8

volodymyr-soltys97 suggested changes Dec 10, 2024

View reviewed changes

requested a review from volodymyr-soltys97

066893c

Valbel93 requested a review from volodymyr-soltys97 December 10, 2024 16:01

add colors fir SASS

803c35b

volodymyr-soltys97 approved these changes Dec 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add #4907

add #4907

Valbel93 commented Dec 7, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

anastasiiavorobiova left a comment

anastasiiavorobiova Dec 8, 2024

anastasiiavorobiova Dec 8, 2024

volodymyr-soltys97 left a comment

volodymyr-soltys97 Dec 9, 2024

volodymyr-soltys97 Dec 9, 2024

volodymyr-soltys97 Dec 9, 2024

volodymyr-soltys97 Dec 9, 2024

etojeDenys Dec 9, 2024

Valbel93 Dec 9, 2024 •

edited

Loading

volodymyr-soltys97 Dec 10, 2024

etojeDenys Dec 9, 2024

Valbel93 Dec 9, 2024

Valbel93 Dec 9, 2024

volodymyr-soltys97 left a comment

volodymyr-soltys97 Dec 10, 2024

volodymyr-soltys97 Dec 10, 2024

volodymyr-soltys97 Dec 10, 2024

volodymyr-soltys97 Dec 10, 2024

volodymyr-soltys97 left a comment

	<div class="stars__reviews">Reviews: 5</div>
	<p class="stars__reviews">Reviews: 5</p>

-      </div>
-      <div
+      </div>
+      <div

add #4907

Are you sure you want to change the base?

add #4907

Conversation

Valbel93 commented Dec 7, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

anastasiiavorobiova left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Valbel93 Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

Valbel93 Dec 9, 2024 •

edited

Loading