Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #4869

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

add solution #4869

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4aee23d
add solution
Knysh19 Nov 24, 2024
cd2e610
add solution
Knysh19 Dec 4, 2024
4df5ee7
add solution
Knysh19 Dec 4, 2024
aa749cc
add solution
Knysh19 Dec 4, 2024
09bf5e8
add solution
Knysh19 Dec 6, 2024
e528285
add solution
Knysh19 Dec 6, 2024
5fee25a
add solution
Knysh19 Dec 7, 2024
fac84f8
add solution
Knysh19 Dec 10, 2024
efe60f6
add solution
Knysh19 Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
294 changes: 293 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,298 @@
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<img
class="logo"
src="./images/logo.png"
alt="Moyo Logo"
/>
<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
class="nav__link is-active"
href="#"
>
Apple
</a>
</li>
<li class="nav__link">Samsung</li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every word should be a link, fix it everywhere

Suggested change
<li class="nav__item">
<a
class="nav__link is-active"
href="#"
>
Apple
</a>
</li>
<li class="nav__link">Samsung</li>
<li class="nav__item">
<a
class="nav__link is-active"
href="#apple"
>
Apple
</a>
</li>
<li class="nav__item">
<a class="nav__link" href="#samsung">Samsung</a>
</li>

<li class="nav__link">Smartphones</li>
<li
class="nav__link"
data-qa="nav-hover"
>
Laptops & Computers
</li>
<li class="nav__link">Gadgets</li>
<li class="nav__link">Tablets</li>
<li class="nav__link">Photo</li>
<li class="nav__link">Video</li>
</ul>
</nav>
</header>

<main class="container">
<div
class="card"
data-qa="card"
>
<img
class="card__image"
src="./images/imac.jpeg"
alt="iMac"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
<div class="card__review">
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
Comment on lines +119 to +125
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it everywhere

Suggested change
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

<p class="card__review_count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price_text">Price:</p>
<p class="card__price_count">$2,199</p>
</div>
<a
href="#"
class="card__button"
data-qa="card-hover"
>
BUY
</a>
</div>

<div class="card">
<img
class="card__image"
src="./images/imac.jpeg"
alt="iMac"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
<div class="card__review">
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
<p class="card__review_count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price_text">Price:</p>
<p class="card__price_count">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
BUY
</a>
</div>

<div class="card">
<img
class="card__image"
src="./images/imac.jpeg"
alt="iMac"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
<div class="card__review">
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
<p class="card__review_count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price_text">Price:</p>
<p class="card__price_count">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
BUY
</a>
</div>

<div class="card">
<img
class="card__image"
src="./images/imac.jpeg"
alt="iMac"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
<div class="card__review">
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
<p class="card__review_count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price_text">Price:</p>
<p class="card__price_count">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
BUY
</a>
</div>

<div class="card">
<img
class="card__image"
src="./images/imac.jpeg"
alt="iMac"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
<div class="card__review">
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
<p class="card__review_count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price_text">Price:</p>
<p class="card__price_count">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
BUY
</a>
</div>

<div class="card">
<img
class="card__image"
src="./images/imac.jpeg"
alt="iMac"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
<div class="card__review">
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
<p class="card__review_count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price_text">Price:</p>
<p class="card__price_count">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
BUY
</a>
</div>

<div class="card">
<img
class="card__image"
src="./images/imac.jpeg"
alt="iMac"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
<div class="card__review">
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
<p class="card__review_count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price_text">Price:</p>
<p class="card__price_count">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
BUY
</a>
</div>

<div class="card">
<img
class="card__image"
src="./images/imac.jpeg"
alt="iMac"
/>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>
<p class="card__code">Product code: 195434</p>
<div class="card__review">
<div class="stars">
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star-active"></div>
<div class="stars__star"></div>
</div>
<p class="card__review_count">Reviews: 5</p>
</div>
<div class="card__price">
<p class="card__price_text">Price:</p>
<p class="card__price_count">$2,199</p>
</div>
<a
href="#"
class="card__button"
>
BUY
</a>
</div>
Comment on lines +141 to +363
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product card elements are repeated multiple times with identical content. Consider using a templating engine or JavaScript to dynamically generate these cards to avoid redundancy and improve maintainability.

</main>
</body>
</html>
Loading
Loading