Develop #4451
Open
Develop #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiavorobiova
suggested changes
Jun 17, 2024
| </a> | ||
| </li> | ||
| </ul> | ||
| </nav> |
There was a problem hiding this comment.
Check styles for active and hover links
| transition: transform 300ms; | ||
| } | ||
|
|
||
| img { |
There was a problem hiding this comment.
Consider using class selectors for styling
| background-repeat: no-repeat; | ||
| width: 160px; | ||
| height: 134px; | ||
| margin-bottom: 40px; |
There was a problem hiding this comment.
Suggested change
| margin-bottom: 40px; | |
| margin: 0 auto 40px; | |
| display: block; |
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <p class="card__review">Reviews:5</p> |
There was a problem hiding this comment.
Suggested change
| <p class="card__review">Reviews:5</p> | |
| <p class="card__review">Reviews: 5</p> |
There was a problem hiding this comment.
There is space between words
|
|
||
| .card__title { | ||
| width: 100%; | ||
| height: 36px; |
There was a problem hiding this comment.
Suggested change
| height: 36px; |
| } | ||
| } | ||
|
|
||
| [data-qa='nav-hover']:hover { |
There was a problem hiding this comment.
Consider using class selectors
| } | ||
|
|
||
| [data-qa='nav-hover']:hover { | ||
| color: #00acdc; |
There was a problem hiding this comment.
Consider using variables for repeating colors
Comment on lines
+48
to
+49
| width: 98px; | ||
| height: 14px; |
There was a problem hiding this comment.
Suggested change
| width: 98px; | |
| height: 14px; |
| background-image: url(../../images/star.svg); | ||
| } | ||
|
|
||
| .stars--4 :nth-child(-n + 4) { |
There was a problem hiding this comment.
All modifiers should be working. Consider using classes from the previous task for them
| .main { | ||
| box-sizing: border-box; | ||
| width: 944px; | ||
| height: 100vh; |
There was a problem hiding this comment.
Suggested change
| height: 100vh; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
All component follow BEM and use SCSS
repaeted sizes and special colors are put to variables
Grid is used for the columns
cards are shown in 1, 2, 3 or 4 columns based on screen resolution
All changes on
:hoverare smoothCode follows all the Code Style Rules ❗️