add task solution #4450
Open
add task solution #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksandrHaman
commented
Jun 17, 2024
OleksandrHaman
commented
- DEMO LINK
- TEST REPORT LINK
anastasiiavorobiova
suggested changes
Jun 17, 2024
src/styles/header.scss
Outdated
|
|
||
| body { | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
Consider moving general styles to a separate file
src/styles/product-card.scss
Outdated
| height: $imageHeight; | ||
| align-items: center; | ||
| margin-bottom: 40px; | ||
| padding-left: 3px; |
There was a problem hiding this comment.
Suggested change
| padding-left: 3px; | |
| margin-right: auto; | |
| margin-left: auto; |
src/styles/product-card.scss
Outdated
| transition: all $transitionTime; | ||
|
|
||
| &__title { | ||
| margin: 0; |
There was a problem hiding this comment.
Suggested change
| margin: 0; |
src/styles/product-card.scss
Outdated
| font-weight: 500; | ||
| font-size: 12px; | ||
| line-height: 18px; | ||
| margin-bottom: 4px; |
There was a problem hiding this comment.
Suggested change
| margin-bottom: 4px; | |
| margin: 0 0 5px; |
src/styles/product-card.scss
Outdated
| } | ||
|
|
||
| &__code { | ||
| margin: 0; |
There was a problem hiding this comment.
Suggested change
| margin: 0; |
src/styles/product-card.scss
Outdated
| font-weight: 400; | ||
| font-size: 10px; | ||
| color: #616070; | ||
| margin-bottom: 16px; |
There was a problem hiding this comment.
Suggested change
| margin-bottom: 16px; | |
| margin: 0 0 17px;; |
src/styles/product-card.scss
Outdated
|
|
||
| &:hover { | ||
| border: $headerColor solid 1px; | ||
| background-color: #fff; |
There was a problem hiding this comment.
Consider using variables for repeating colors
src/styles/product-card.scss
Outdated
| font-family: $mainFont; | ||
| font-size: 14px; | ||
| border-style: none; | ||
| width: 166px; |
There was a problem hiding this comment.
Suggested change
| width: 166px; | |
| width: 100%; |
anastasiiavorobiova
suggested changes
Jun 17, 2024
src/styles/index.scss
Outdated
| html { | ||
| font-family: Roboto, sans-serif; | ||
| } | ||
|
|
||
| body { | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
Move general styles to a separate file
| } | ||
| } | ||
|
|
||
| .product-card { |
There was a problem hiding this comment.
Move card styles to a separate file
src/styles/product-card.scss
Outdated
| width: $imageWidth; | ||
| height: $imageHeight; | ||
| align-items: center; | ||
| margin-bottom: 40px; |
There was a problem hiding this comment.
Suggested change
| margin-bottom: 40px; | |
| margin: 0 auto 40px; |
lerastarynets
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.