add task solution #4203
Open
add task solution #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdPirro
suggested changes
Mar 11, 2024
There was a problem hiding this comment.
Great job, @ropanefarias! I spotted just a minor required fix for your solution to perfectly complete the assignment, please have a look at it. Other than that your code looks clean👏
src/styles/main/card.scss
Outdated
Comment on lines
24
to
26
| &:hover { | ||
| color: #34568b; | ||
| } |
There was a problem hiding this comment.
Card title should change color when the card itself is hovered, not when the title is hovered Referece
mgrinko
reviewed
Mar 12, 2024
EdPirro
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
❗️ Copy this
Checklistto thePull Requestdescription after links, and put- [x]before each point after you checked it.[x] All component follow BEM and use SCSS
[x] repaeted sizes and special colors are put to variables
[x] Grid is used for the columns
[x] cards are shown in 1, 2, 3 or 4 columns based on screen resolution
[x] All changes on
:hoverare smooth[x] Code follows all the Code Style Rules ❗️