Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #4195

Closed
wants to merge 7 commits into from
Closed

Develop #4195

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2024

  • DEMO LINK
  • TEST REPORT LINK
  • All component follow BEM and use SCSS
  • repaeted sizes and special colors are put to variables
  • Grid is used for the columns
  • cards are shown in 1, 2, 3 or 4 columns based on screen resolution
  • All changes on :hover are smooth
  • Code follows all the Code Style Rules ❗️

pedro-ruas
pedro-ruas suggested changes Mar 11, 2024
View reviewed changes
Copy link

@pedro-ruas pedro-ruas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vinicius, your code looks great for the most part.
There is 2 animation issues (actually, it's one issue that happens twice)
And you missed 1 item on the checklist, but easy fix.

src/styles/card.scss Outdated Show resolved Hide resolved
src/styles/card.scss Outdated Show resolved Hide resolved
src/styles/card.scss Outdated Show resolved Hide resolved
src/styles/stars.scss Outdated Show resolved Hide resolved
src/styles/vars.scss Outdated Show resolved Hide resolved
src/styles/vars.scss Show resolved Hide resolved
@ghost ghost requested a review from pedro-ruas March 12, 2024 17:17
mgrinko
mgrinko reviewed Mar 12, 2024
View reviewed changes
readme.md Show resolved Hide resolved
EdPirro
EdPirro suggested changes Mar 12, 2024
View reviewed changes
Copy link

@EdPirro EdPirro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort, @vinasxz! 👏 You're almost there, please thoroughly review the requested changes, if you have any questions please ask them in the qna channel!

src/styles/card.scss Show resolved Hide resolved
src/styles/card.scss Outdated Show resolved Hide resolved
src/styles/header.scss Outdated Show resolved Hide resolved
src/styles/header.scss Outdated Show resolved Hide resolved
src/styles/stars.scss Show resolved Hide resolved
@ghost ghost requested a review from EdPirro March 13, 2024 11:35
pedro-ruas
pedro-ruas suggested changes Mar 13, 2024
View reviewed changes
src/styles/stars.scss Outdated Show resolved Hide resolved
@ghost ghost requested a review from pedro-ruas March 14, 2024 19:49
EdPirro
EdPirro approved these changes Mar 14, 2024
View reviewed changes
Copy link

@EdPirro EdPirro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @vinasxz! Your solution looks great and fulfills all the requirements. Keep it up! 🚀

@ghost ghost closed this by deleting the head repository Jun 7, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro-ruas pedro-ruas Awaiting requested review from pedro-ruas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgrinko @EdPirro @pedro-ruas @vinasxz