login method and findByEmail method added #1143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Dec 3, 2024
| @@ -15,6 +15,11 @@ public class UserService { | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
| for (User tempUser: users) { | |||
There was a problem hiding this comment.
Suggested change
| for (User tempUser: users) { | |
| for (User user : users) { |
use space before and after semicolon
| return true; | ||
| } | ||
| } | ||
| System.out.println("No user with this e-mail is found"); |
There was a problem hiding this comment.
don't forget to remove sout (system.out.println) from your solution before committing your HW
| @@ -11,6 +13,14 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService serv = new UserService(); | |||
There was a problem hiding this comment.
don't shorten your local variables' names, be verbose! 🙏 Remember, developers spend much more time reading the code of others than writing their own, time saved by not typing out a few extra letters is not worth it
| @@ -11,6 +13,14 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService serv = new UserService(); | |||
There was a problem hiding this comment.
Suggested change
| UserService serv = new UserService(); | |
| UserService userService = new UserService(); |
Comment on lines
17
to
24
| User user = serv.findByEmail(email); | ||
| if (user != null) { | ||
| if (user.getPassword().equals(password)) { | ||
| return true; | ||
| } | ||
| } | ||
| System.out.println("No user with this e-mail is found"); | ||
| return false; |
There was a problem hiding this comment.
try to rewrite this solution without using boolean literals (true/false) at all. Use logical expressions directly in return
a whitespace before and after semicolon added variable names changed to be more descriptive System.out.println removed
Elena-Bruyako
suggested changes
Dec 10, 2024
| @@ -1,5 +1,7 @@ | |||
| package mate.academy.service; | |||
|
|
|||
| import mate.academy.model.User; | |||
|
|
|||
| public class AuthenticationService { | |||
There was a problem hiding this comment.
Suggested change
| public class AuthenticationService { | |
| public class AuthenticationService { | |
| private final UserService userService = new UserService(); |
There was a problem hiding this comment.
I receive the message: "Modifier 'private' is not allowed here"
| @@ -11,6 +13,13 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService newService = new UserService(); | |||
There was a problem hiding this comment.
Suggested change
| UserService newService = new UserService(); |
Co-authored-by: Olena Bruiako <[email protected]>
Elena-Bruyako
suggested changes
Dec 10, 2024
| return false; | ||
| final UserService newService = new UserService(); | ||
| User user = newService.findByEmail(email); | ||
| return user != null && user.getPassword().equals(password)); |
There was a problem hiding this comment.
Suggested change
| return user != null && user.getPassword().equals(password)); | |
| return user != null && user.getPassword().equals(password); |
| @@ -1,5 +1,7 @@ | |||
| package mate.academy.service; | |||
|
|
|||
| import mate.academy.model.User; | |||
|
|
|||
| public class AuthenticationService { | |||
Comment on lines
+18
to
+20
| for (User temporalUser : users) { | ||
| if (temporalUser.getEmail().equals(email)) { | ||
| return temporalUser; |
There was a problem hiding this comment.
Suggested change
| for (User temporalUser : users) { | |
| if (temporalUser.getEmail().equals(email)) { | |
| return temporalUser; | |
| for (User user : users) { | |
| if (user.getEmail().equals(email)) { | |
| return user; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.