Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done #1735

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

done #1735

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,10 @@
public class Application {
public static void main(String[] args) {
// create three balls using class Lottery and print information about them in console
for (int i = 0; i < 3; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make 3 constant field

Lottery lottery = new Lottery();
Ball ball = lottery.getRandomBall();
System.out.println(ball);
}
}
}
27 changes: 27 additions & 0 deletions src/main/java/core/basesyntax/Ball.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package core.basesyntax;

public class Ball {
private Colors color;
private int number;

public void setColor(Colors color) {
this.color = color;
}

public String getColor() {
return this.color.toString();
}

public void setNumber(int number) {
this.number = number;
}

public int getNumber() {
return this.number;
}

@Override
public String toString() {
return "Ball [Color = " + color + ", Number = " + number + "]";
}
}
8 changes: 6 additions & 2 deletions src/main/java/core/basesyntax/ColorSupplier.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package core.basesyntax;

import java.util.Random;

public class ColorSupplier {
public String getRandomColor() {
return null;
public Colors getRandomColor() {
Random random = new Random();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random should be a private final class level variable

int index = random.nextInt(Colors.values().length);
return Colors.values()[index];
}
}
10 changes: 10 additions & 0 deletions src/main/java/core/basesyntax/Colors.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package core.basesyntax;

public enum Colors {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public enum Colors {
public enum Color {

RED,
BLUE,
GREEN,
YELLOW,
ORANGE,
BLACK
}
15 changes: 15 additions & 0 deletions src/main/java/core/basesyntax/Lottery.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package core.basesyntax;

import java.util.Random;

public class Lottery {
public Ball getRandomBall() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random and ColorSuplier should be a private final class level variable

Ball ball = new Ball();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, you can create a constructor with parameters for the Ball model and simplify your solution.

ColorSupplier colorSupplier = new ColorSupplier(); // Create a ColorSupplier object

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant comment

Colors randomColor = colorSupplier.getRandomColor();
ball.setColor(randomColor);
int randomValue = new Random().nextInt(100);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make magic number constant field

ball.setNumber(randomValue);
return ball;
}
}
Loading