Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented lottery class with colorSupplier and Ball class #1732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

public class Application {
public static void main(String[] args) {
// create three balls using class Lottery and print information about them in console
Lottery lottery = new Lottery();

Ball ball1 = lottery.getRandomBall();
Ball ball2 = lottery.getRandomBall();
Ball ball3 = lottery.getRandomBall();

System.out.println(ball1.toString());
System.out.println(ball2.toString());
System.out.println(ball3.toString());
Comment on lines +7 to +13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a loop to create and print the Ball objects. This approach is recommended in the checklist to avoid redundancy and improve code maintainability. You can create an array or list to store the balls and iterate over it to print their details.

}
}
32 changes: 32 additions & 0 deletions src/main/java/core/basesyntax/Ball.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package core.basesyntax;

public class Ball {
private Color color;
private Integer number;

public Ball(Color color, Integer number) {
this.color = color;
this.number = number;
}

@Override
public String toString() {
return this.color.toString() + this.number.toString();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a separator between color and number in the toString method for better readability. For example, you could use a space or a hyphen.

}

public Color getColor() {
return color;
}

public void setColor(Color color) {
this.color = color;
}

public Integer getNumber() {
return number;
}

public void setNumber(Integer number) {
this.number = number;
}
}
9 changes: 9 additions & 0 deletions src/main/java/core/basesyntax/Color.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package core.basesyntax;

public enum Color {
RED,
BROWN,
YELLOW,
GREEN,
BLUE
}
9 changes: 7 additions & 2 deletions src/main/java/core/basesyntax/ColorSupplier.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
package core.basesyntax;

import java.util.Random;

public class ColorSupplier {
public String getRandomColor() {
return null;
public Color getRandomColor() {
Random random = new Random();
int index = random.nextInt(Color.values().length);

return Color.values()[index];
}
}
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Lottery.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

import java.util.Random;

public class Lottery {
public Ball getRandomBall() {
ColorSupplier colorSupplier = new ColorSupplier();

Color color = colorSupplier.getRandomColor();
Integer number = new Random().nextInt(101);

return new Ball(color, number);
}
}
Loading