implement random ball generation for lottery system #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Great job on implementing the solution! 🎉 Your code meets the task requirements and constraints effectively. While there is a minor suggestion to define the number of balls as a constant to avoid magic numbers, it doesn't impact the functionality. Keep up the good work and consider this improvement for future projects to enhance code readability and maintainability. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,7 +1,16 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Application { | |||
| private static final Lottery lottery = new Lottery(); | |||
There was a problem hiding this comment.
Consider defining the number of balls as a constant to avoid magic numbers. This aligns with the checklist item: 'All magic numbers in your code should be constants.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.