Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created a lottery about balls with random number and color #1719

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sokoligor29
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code is well-structured and meets the core requirements. The only minor suggestion is to use the name() method instead of toString() for getting the string representation of enum constants in the ColorSupplier class. This ensures a more reliable output. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +8 to +9
Colors color = Colors.values()[index];
return color.toString();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using toString() to get the string representation of the enum constant, use the name() method. This is a more reliable way to get the string representation of an enum constant as it directly returns the name of the constant. Refer to the checklist: 'Use name() for getting String representation of enum constants'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants