solution lottery

[Serhiircv]

No description provided.

[mateacademy-ai-mentor]

---

Thank you for your submission! While your code is on the right track, there are a few critical issues that need to be addressed to meet the core requirements of the task:

1. Lottery Class:

   • The Lottery class should not extend ColorSupplier as it does not represent a "is-a" relationship. This inheritance is unnecessary and incorrect.
   • The randomColor and randomInt fields are incorrectly used. They should be generated within the getRandomBall() method to ensure each Ball object has a unique color and number.

2. ColorSupplier Class:

   • The randomColor field should be removed, and the getRandomColor() method should be used directly to ensure a new random color is generated each time.

3. Application Class:

   • Creating multiple instances of Lottery is unnecessary. Use a loop to generate multiple random balls with a single instance for better maintainability and readability.

4. Enum Usage:

   • Use the name() method instead of String.valueOf() to get the string representation of enum constants, as it ensures the correct representation is always returned.

These changes are essential to ensure the functionality and correctness of your code. Keep up the good work, and I'm confident you'll nail it with these adjustments! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

[mateacademy-ai-mentor]

Consider using a loop to create multiple instances of the Lottery class. This approach is recommended for better code maintainability and readability, as mentioned in the checklist: 'Use for loop for creating several objects of the same class'.

[mateacademy-ai-mentor]

Instead of using String.valueOf(Colors.values()[index]), use Colors.values()[index].name() to get the string representation of the enum constant. This follows the checklist recommendation to use name() for getting String representation of enum constants.

[mateacademy-ai-mentor]

The randomInt and randomColor are initialized only once and reused for every Ball object. This means all Ball objects will have the same color and number. Move the random number generation and color assignment inside the getRandomBall() method to ensure each Ball has a unique color and number.

[mateacademy-ai-mentor]

Move the random color and number generation inside the getRandomBall() method to ensure each Ball object has a unique color and number. Call getRandomColor() and random.nextInt(100) within the method.