doneHomework #1248
doneHomework #1248
Conversation
| Lottery lottery1 = new Lottery(); | ||
| Lottery lottery2 = new Lottery(); | ||
| Lottery lottery3 = new Lottery(); |
There was a problem hiding this comment.
Do we need 3 markets to buy 3 milk bottles?
| System.out.println(lottery1.getRandomBall()); | ||
| System.out.println(lottery2.getRandomBall()); | ||
| System.out.println(lottery3.getRandomBall()); |
There was a problem hiding this comment.
Use for loop for creating several objects of the same class
| public class Ball { | ||
|
|
||
| private String color; |
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| public class Application { | |||
| public static void main(String[] args) { | |||
| // create three balls using class Lottery and print information about them in console | |||
| Lottery[] lotteries = {new Lottery(), new Lottery(), new Lottery()}; | |||
There was a problem hiding this comment.
you need only one lottery here
| Lottery[] lotteries = {new Lottery(), new Lottery(), new Lottery()}; | |
| Lottery lottery = ...; |
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| int index = new Random().nextInt(Colors.values().length); |
| @@ -0,0 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public enum Colors { | |||
There was a problem hiding this comment.
dont use plural form for enums
| public enum Colors { | |
| public enum Color { |
| int randomNumber = new Random().nextInt(100); | ||
| return new Ball(new ColorSupplier().getRandomColor(), randomNumber); |
There was a problem hiding this comment.
make random, colorSupplier the class level vars
|
|
||
| public class Lottery { | ||
| public Ball getRandomBall() { | ||
| int randomNumber = new Random().nextInt(100); |
There was a problem hiding this comment.
100 is a maggic number,
consider making it constant
| public static int getMaxNumber() { | ||
| return MAX_NUMBER; | ||
| } |
There was a problem hiding this comment.
| public static int getMaxNumber() { | |
| return MAX_NUMBER; | |
| } |
| package core.basesyntax; | ||
|
|
||
| public class Ball { | ||
| private static final int MAX_NUMBER = 100; |
There was a problem hiding this comment.
are you suggesting to delete get method for constant?
There was a problem hiding this comment.
and move this constant to lottery and to not add get method for it?
| public static int getMaxNumber() { | ||
| return MAX_NUMBER; | ||
| } |
There was a problem hiding this comment.
You don`t need this method, just use constant
| int maxNumber = Lottery.MAX_NUMBER; | ||
| int randomNumber = random.nextInt(maxNumber); |
There was a problem hiding this comment.
| int maxNumber = Lottery.MAX_NUMBER; | |
| int randomNumber = random.nextInt(maxNumber); | |
| int randomNumber = random.nextInt(MAX_NUMBER); |
No description provided.