Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

renatoveludo
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Animal, Herbivore, and Carnivore classes! 🎉 Your code meets the task requirements and constraints effectively. Just a small tweak: consider changing the condition if (target.health === 0) to if (target.health <= 0) in the Carnivore class to ensure the die method is called correctly. Keep up the excellent work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

if (target.hidden === false) {
target.health -= 50;

if (target.health === 0) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition if (target.health === 0) should be changed to if (target.health <= 0) to ensure that the die method is called when the target's health is less than or equal to 0, not just when it is exactly 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants