Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #2317

wants to merge 1 commit into from

Conversation

bertsu02
Copy link

No description provided.

Copy link

@Timi2424 Timi2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great overall. If you want to resolve conflict with static variable and eslist, I suggest reading this #952

}

class Carnivore extends Animal {
// write your code here
bite(herb) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, herb is a wrong argument name

  1. you can (but shouldn't) pass a carnivore to this function
  2. herb has another meaning as a word. it's like shortening carpet to a car.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just change argument name and its all good yeah ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants