Solution #2230
Solution #2230
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 The code meets the task requirements and constraints effectively. While there are a couple of minor improvements suggested, such as ensuring string concatenation for the year and handling the separator in the toFormat array, these do not significantly impact the functionality. Keep up the good work, and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| const year = parseInt(mapping['YY'], 10); | ||
|
|
||
| if (year < 30) { | ||
| mapping['YYYY'] = 20 + mapping['YY']; |
There was a problem hiding this comment.
The concatenation of 20 with mapping['YY'] should be a string operation. Use mapping['YYYY'] = '20' + mapping['YY']; to ensure the result is a string.
| if (year < 30) { | ||
| mapping['YYYY'] = 20 + mapping['YY']; | ||
| } else { | ||
| mapping['YYYY'] = 19 + mapping['YY']; |
There was a problem hiding this comment.
The concatenation of 19 with mapping['YY'] should be a string operation. Use mapping['YYYY'] = '19' + mapping['YY']; to ensure the result is a string.
| } | ||
| } | ||
|
|
||
| const newSeparator = toFormat[toFormat.length - 1]; |
There was a problem hiding this comment.
Ensure that toFormat always has a separator as its last element. If this is not guaranteed, you might encounter issues with the newSeparator variable.
No description provided.