solution #2162
solution #2162
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 Your solution meets the task requirements and handles the conversion of date formats effectively. While there are some assumptions about the position of separators and century logic for years, these do not critically impact the functionality for the current requirements. Keep up the good work, and consider making these assumptions more flexible in future iterations to enhance the robustness of your code. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -8,7 +8,30 @@ | |||
| * @returns {string} | |||
| */ | |||
| function formatDate(date, fromFormat, toFormat) { | |||
| // write code here | |||
| const separator = fromFormat[3]; | |||
There was a problem hiding this comment.
The separator is assumed to be at index 3 of the fromFormat array. Ensure that this assumption is valid for all expected input formats. If the separator is not always at this position, the logic may need to be adjusted.
| if (fromFormat.includes('YY')) { | ||
| oldDateFormat['YYYY'] = | ||
| parseInt(oldDateFormat['YY'], 10) < 30 | ||
| ? '20' + oldDateFormat['YY'] | ||
| : '19' + oldDateFormat['YY']; |
There was a problem hiding this comment.
The logic for converting 'YY' to 'YYYY' assumes that any year less than 30 is in the 2000s, and any year 30 or greater is in the 1900s. This assumption may not hold for all use cases, especially if the input date could be from a different century. Consider making this logic more flexible or configurable.
| oldDateFormat['YY'] = oldDateFormat['YYYY'].slice(-2); | ||
| } | ||
|
|
||
| const newSeparator = toFormat[3]; |
There was a problem hiding this comment.
Similar to the fromFormat, the separator is assumed to be at index 3 of the toFormat array. Ensure this assumption is valid for all expected output formats.
No description provided.