Solution #1694

afesh4ak · 2023-12-02T15:49:35Z

No description provided.

anastasiiavorobiova

Great work! Added a few comments to fix

anastasiiavorobiova · 2023-12-03T13:29:14Z

src/formatDate.js

+
+  const result = toFormat
+    .map((part) => {
+      if (part.includes('YY')) {


Consider using variables with meaningful names instead of magic strings

anastasiiavorobiova · 2023-12-03T13:29:53Z

src/formatDate.js

-  // write code here
+  const parts = date.split(fromFormat[fromFormat.length - 1]);
+  const resultMap = new Map();
+


Suggested change

const LONG_YEAR_FORMAT = 'YYYY';

anastasiiavorobiova · 2023-12-03T13:30:13Z

src/formatDate.js

+  const result = toFormat
+    .map((part) => {
+      if (part.includes('YY')) {
+        let year = resultMap.get('YYYY');


Suggested change

let year = resultMap.get('YYYY');

let year = resultMap.get(LONG_YEAR_FORMAT);

anastasiiavorobiova · 2023-12-03T13:30:50Z

src/formatDate.js

+    })
+    .join(toFormat[toFormat.length - 1]);
+
+  return result.endsWith(toFormat[toFormat.length - 1])


Consider simplifying this logic

I use this logic to slice last separator, if date ends with separator

Solution

d49135f

anastasiiavorobiova suggested changes Dec 3, 2023

View reviewed changes

Solution

5148a96

afesh4ak requested a review from anastasiiavorobiova December 3, 2023 21:04

OleziO approved these changes Dec 4, 2023

View reviewed changes

Provide feedback

	let year = resultMap.get('YYYY');
	let year = resultMap.get(LONG_YEAR_FORMAT);