This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Cleanup #111
Merged
Cleanup #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bjrne
commented
Jul 10, 2020
bjrne
commented
- Merge src and utils folder
- Name configuration folders consistently
| @@ -7,7 +7,7 @@ | |||
| import numpy as np | |||
|
|
|||
| from apps.matching.files.map_data import plzs | |||
| from apps.matching.src.plzs import BIG_CITY_PLZS | |||
| from apps.matching.utils.plzs import BIG_CITY_PLZS | |||
There was a problem hiding this comment.
as we're cleaning this up, suggest renaming to zipcode? Should we use singular or plural here?
Baschdl
approved these changes
Jul 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.