Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade AGP to 8.4.1, Gradle to 8.6, JDK to 17, and Kotlin to 1.9.24 #82

Merged

Conversation

AristideVB
Copy link
Contributor

@AristideVB AristideVB commented May 23, 2024

Description :

  • Upgrade Android Gradle Plugin to 8.4.1
  • Upgrade Gradle to 8.6
  • Migrate JDK version from 1.8 to 17
  • Upgrade Kotlin from 1.8.22 to 1.9.24

Fixes issue #71

@matanshukry 🙏

- Update Android Gradle Plugin to 8.3.1
- Migrate JDK version from 1.8 to 17
- Upgrade Kotlin from 1.8.22 to 1.9.23
@AristideVB AristideVB changed the title feat: upgrade AGP to 8.3.1, JDK to 17, and Kotlin to 1.9.23 feat: upgrade AGP to 8.4.1, Gradle to 8.6, JDK to 17, and Kotlin to 1.9.23 Jun 1, 2024
@AristideVB AristideVB changed the title feat: upgrade AGP to 8.4.1, Gradle to 8.6, JDK to 17, and Kotlin to 1.9.23 feat: upgrade AGP to 8.4.1, Gradle to 8.6, JDK to 17, and Kotlin to 1.9.24 Jun 1, 2024
@Vlad-Adrian
Copy link

hello @fleoparra @matanshukry, is there a timeline for when this should be merged? In case there are unsolved issues I would gladly help solving them

@fleoparra
Copy link
Contributor

hello @fleoparra @matanshukry, is there a timeline for when this should be merged? In case there are unsolved issues I would gladly help solving them

Hello @Vlad-Adrian. No, there is no timeline for this. The merge depends on the owner of the library. As an alternative, you can use @AristideVB's fork https://github.com/AristideVB/flutter_google_places_sdk/tree/feat/agp_jdk_kotlin_upgrade if you need to use Gradle 8.

@matanshukry matanshukry merged commit 8f03f47 into matanshukry:master Jun 28, 2024
0 of 2 checks passed
@TatsuUkraine TatsuUkraine mentioned this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants