-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply languageIdentifier attribute to user-generated content where possible #881
Open
j-f1
wants to merge
9
commits into
mastodon:develop
Choose a base branch
from
j-f1:a11y-attributes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4126385
Fix accessibility label for posts with custom emoji
j-f1 95e1cbd
Use languageIdentifier attribute to ensure VoiceOver switches languag…
j-f1 900cdb2
Read media alt text in posts with the correct language
j-f1 0eca019
Add AttributeContainer shorthand for defining an attribute
j-f1 730c064
Apply the post language to the media preview image description
j-f1 01dd678
Apply the post language to the AltTextViewController
j-f1 56e7545
Remove language tag when translation is enabled
j-f1 295addc
Add missing 'status' property to StatusEdit
j-f1 75274dd
Fix build error
j-f1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
MastodonSDK/Sources/MastodonExtension/AttributeContainer.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright © 2023 Mastodon gGmbH. All rights reserved. | ||
|
||
import Foundation | ||
|
||
extension AttributeContainer { | ||
public init<T>(_ attribute: WritableKeyPath<AttributeContainer, T>, value: T) { | ||
self.init() | ||
self[keyPath: attribute] = value | ||
} | ||
|
||
public init<T>(_ attribute: WritableKeyPath<AttributeContainer, T>, value: T?) { | ||
self.init() | ||
if let value { | ||
self[keyPath: attribute] = value | ||
} | ||
} | ||
} |
25 changes: 25 additions & 0 deletions
25
MastodonSDK/Sources/MastodonExtension/NSAccessibility.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// Copyright © 2023 Mastodon gGmbH. All rights reserved. | ||
|
||
import UIKit | ||
|
||
extension NSObject { | ||
@inlinable public var attributedAccessibilityLabel: AttributedString? { | ||
get { accessibilityAttributedLabel.map(AttributedString.init) } | ||
set { accessibilityAttributedLabel = newValue.map(NSAttributedString.init) } | ||
} | ||
|
||
@inlinable public var attributedAccessibilityValue: AttributedString? { | ||
get { accessibilityAttributedValue.map(AttributedString.init) } | ||
set { accessibilityAttributedValue = newValue.map(NSAttributedString.init) } | ||
} | ||
|
||
@inlinable public var attributedAccessibilityHint: AttributedString? { | ||
get { accessibilityAttributedHint.map(AttributedString.init) } | ||
set { accessibilityAttributedHint = newValue.map(NSAttributedString.init) } | ||
} | ||
|
||
@inlinable public var attributedAccessibilityUserInputLabels: [AttributedString]! { | ||
get { accessibilityAttributedUserInputLabels?.map(AttributedString.init) } | ||
set { accessibilityAttributedUserInputLabels = newValue?.map(NSAttributedString.init) } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// Copyright © 2023 Mastodon gGmbH. All rights reserved. | ||
|
||
import Foundation | ||
|
||
extension Collection<AttributedString> { | ||
// ref: https://github.com/apple/swift/blob/700bcb4e4b97da61517c8b8831c72015207612f9/stdlib/public/core/String.swift#L727-L750 | ||
@inlinable public func joined(separator: AttributedString = "") -> AttributedString { | ||
var result: AttributedString = "" | ||
if separator.characters.isEmpty { | ||
for x in self { | ||
result.append(x) | ||
} | ||
return result | ||
} | ||
|
||
var iter = makeIterator() | ||
if let first = iter.next() { | ||
result.append(first) | ||
while let next = iter.next() { | ||
result.append(separator) | ||
result.append(next) | ||
} | ||
} | ||
return result | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Does the CoreData model already reflect this relationship? I haven't seen any changes to our Model in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes:
mastodon-ios/MastodonSDK/Sources/CoreDataStack/CoreData.xcdatamodeld/CoreData 8.xcdatamodel/contents
Line 255 in d24fe00