Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the DefaultObjTagMap return null as tag, if the given object was … #358

Merged

Conversation

stefanhahmann
Copy link
Collaborator

This PR fixes a bug when repainting the branch graph.

It occurred in a very specific situation, when:

  1. Spots are deleted in trackscheme, such as that complete tracks disappear
  2. The branch graph is not immediately synced in such cases (since otherwise, it would need to be synced too often)
  3. This leads to a weird state in the branch graph view
  4. The clustering command contains perform a sync on the branch graph, before it is performed
  5. The sync on the branch graph leads to a repaint of the branch graph view
  6. Since the branch graph view still contains the non-existing branches, it is looking for tags for objects that do actually not exist anymore, which resulted in a nullpointerexception

Visualisation:
GIF 05 12 2024 11-01-57

Solution:
Comparably easy: let the DefaultObjTagMap return null as tag, if the object given to it was null

@stefanhahmann stefanhahmann self-assigned this Dec 5, 2024
@stefanhahmann stefanhahmann requested a review from tinevez December 5, 2024 10:06
@tinevez tinevez merged commit d261804 into mastodon-sc:dev Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants