Use pending file during save #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
stefanhahmann
force-pushed
the
use-pending-file-during-save
branch
2 times, most recently
from
df0a011 to
81537f5
Compare
stefanhahmann
force-pushed
the
use-pending-file-during-save
branch
from
81537f5 to
3b739e6
Compare
tinevez
reviewed
Jun 26, 2024
…rocess was successful and not interrupted * Strategy to achieve this: * When saving the mastodon project files, they are first saved to projectfile.mastodon_pending (in the zip file case) or projectfolder_pending (in the directory case) * When saving was successful, projectfile.mastodon gets overwritten with projectfile.mastodon_pending (in the zip file case) or projectfolder get overwritten with projectfolder_pending (in the directory case) * In the past, it has been observed that *.mastodon files were corrupted and could not be read anymore * Typical saving times for a project range from ~0.2s to ~2s (depending on project size, attributes, etc.). Not very long, but long enough to kill mastodon during the saving process.
* Saving/Loading Projects in Mastodon is currently not possible in a headless way * To be able to run e.g. unit tests in a headless environment a display needs to be simulated
* tests saving a project to a zip file and a directory
stefanhahmann
force-pushed
the
use-pending-file-during-save
branch
from
3b739e6 to
73cfce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #310
The goal of this PR is to ensure that the actual project file is only overwritten, when the saving process was successful and not interrupted
Motivation for this: