Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online mean/covariance computation to existing mean and covariance demo #15

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

stefanhahmann
Copy link
Collaborator

This PR does the following 3 changes:

  • Make ComputeMeanAndVarianceDemo functional again by adding a Context in the wrapAsAppModel method of DemoUtils
  • Add computation of online mean and online covariance and compare the results and performance to the existing two-pass solution
  • Avoid redundant computations in the two-pass solution to make the performance comparison more realistic

* This fixes the NullPointerException when using the ProjectModel resulting from the wrapAsAppModel method
@stefanhahmann stefanhahmann self-assigned this Mar 5, 2024
@stefanhahmann stefanhahmann requested a review from maarzt March 5, 2024 12:43
@stefanhahmann stefanhahmann force-pushed the online_covariance_demo branch from e9dae0d to 00a3a1a Compare March 6, 2024 10:08
@tinevez tinevez merged commit bec0e39 into master Mar 8, 2024
1 check passed
@tinevez tinevez deleted the online_covariance_demo branch March 8, 2024 09:06
@maarzt maarzt removed their request for review March 14, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants