Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the usage of currentColor #15

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

alexander-schranz
Copy link
Member

Currently currentColor is converted to currentcolor but should stay as currentColor for readability.

https://stylelint.io/user-guide/rules/value-keyword-case/#camelcasesvgkeywords-true--false-default-false

@alexander-schranz alexander-schranz force-pushed the feature/value-keyword-case branch from 5d9b6b5 to 56022ed Compare October 18, 2022 22:11
@@ -0,0 +1,3 @@
.test {
color: currentColor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://css-tricks.com/currentcolor/ cant we use currentcolor? but yeah seems good for me :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can but it looks just false for me 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec also reference it as currentColor: https://www.w3.org/TR/css-color-3/#currentcolor

@alexander-schranz alexander-schranz merged commit feabf10 into master Oct 21, 2022
@alexander-schranz alexander-schranz deleted the feature/value-keyword-case branch October 21, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants