Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rest api #18

Merged
merged 64 commits into from
Apr 3, 2015
Merged

Feature/rest api #18

merged 64 commits into from
Apr 3, 2015

Conversation

dantleech
Copy link
Contributor

This PR adds a Doctrine ORM subscriber, REST API and ExpressionLanaugage and numerous other features facilitating the creation of an independent back office search.

  • Added Doctrine ORM subscriber will automatically index/deindex mapped ORM documents.
  • massive:search:index:rebuild command which rebuilds both the ORM and third-party (i.e. Sulu) implementations)
  • Introduction of a REST API to provide a simple controller to perform a search query using parameters query, index and locale and receieve a JSON response.
  • Introduction of multiple search contexts for each mapped object, possiblity to index things differently for back or front office searches.
  • Added behat tests
  • Category support
  • Docs in separate PR: Massive Search Documentation #20

@@ -0,0 +1,92 @@
<?php

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header

@dantleech
Copy link
Contributor Author

todo:

  • Context: Different URLs (and possibly images, body, title etc) are required for backend and frontend, should add a context context=backend for the mappings.

namespace Massive\Bundle\SearchBundle\Search\Metadata;

/**
* Simple value object for representing propertys
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

properties

@dantleech dantleech force-pushed the feature/rest-api branch 2 times, most recently from 91c70fc to 3c45d19 Compare February 6, 2015 11:57
@dantleech dantleech force-pushed the feature/rest-api branch 3 times, most recently from 0757a67 to b4be1da Compare February 13, 2015 10:13
path: /search
defaults:
_controller: "massive_search.controller.rest:searchAction"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove EL

@dantleech
Copy link
Contributor Author

Thanks @aitboudad I have added tests for invalid field mapping.

@dantleech dantleech force-pushed the feature/rest-api branch 3 times, most recently from 64512a9 to fb69ddc Compare March 16, 2015 09:42
@danrot
Copy link
Contributor

danrot commented Mar 31, 2015

Will this still work with the old search stuff in Sulu? Or should it be merged together with the Sulu PR?

@dantleech
Copy link
Contributor Author

@danrot people should be using the tagged version so I would say it can be merged at any time.

danrot added a commit that referenced this pull request Apr 3, 2015
@danrot danrot merged commit 67a3fd4 into develop Apr 3, 2015
@danrot danrot removed the review label Apr 3, 2015
@danrot danrot deleted the feature/rest-api branch April 3, 2015 12:31
@danrot
Copy link
Contributor

danrot commented Apr 3, 2015

Merged, but Sulu won't work with this. For the next Sulu release we have to tag 0.5.0 and sulu/sulu#797 must be merged.

alexander-schranz pushed a commit to alexander-schranz/MassiveSearchBundle that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants