Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the readme #30

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Sep 20, 2024

  • Removing outdated requirements (just look at the composer.json)
  • Removing outdated Symfony documentation (just use dependency injection)

Comment on lines -117 to -128
You can access the service container by implementing the
`ContainerAwareInterface`:

````php
<?php
// ...

class MyBuilder implements ContainerAwareInterface, BuilderInterface
{
// ...
}
````
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this also means that we can stop supporting our own ContainerAwareInterface

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still support via Massive\Bundle\BuildBundle\ContainerAwareInterface for this but I think we can still remove it from the README as the way to go should be dependency injection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in a later version we could just stop supporting this feature altogether. Not part of this PR.

@alexander-schranz alexander-schranz merged commit 0b1a5c7 into massiveart:0.5 Sep 20, 2024
4 of 7 checks passed
@mamazu mamazu deleted the update_readme branch September 20, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants