Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor format amount #459

Merged
merged 1 commit into from
Jun 11, 2024
Merged

refactor format amount #459

merged 1 commit into from
Jun 11, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jun 11, 2024

  • removed formatFTAmount, use formatAmount instead
  • renamed amountFormattedFull into full
  • renamed amountFormattedPreview into preview
  • removed formatAmountToDisplay, use parseAmount and formatAmount
  • add story for format amount
  • formatAmount preview has now at least 2 significant digits instead of 1
  • removeTrailingZeros is not exported anymore

@Thykof Thykof requested a review from pivilartisant June 11, 2024 17:48
@Thykof Thykof mentioned this pull request Jun 11, 2024
Merged
2 tasks
@Thykof Thykof self-assigned this Jun 11, 2024
@Thykof Thykof merged commit e5c4eb2 into main Jun 11, 2024
7 checks passed
@Thykof Thykof deleted the format-amount-stories branch June 11, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivilartisant pivilartisant pivilartisant approved these changes

Assignees

@Thykof Thykof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thykof @pivilartisant