Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Test #357

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Button Test #357

merged 5 commits into from
Nov 7, 2023

Conversation

pivilartisant
Copy link
Contributor

No description provided.

@pivilartisant pivilartisant force-pushed the button-test branch 2 times, most recently from 513d930 to 0026244 Compare October 16, 2023 08:25
@mazmassa
Copy link
Contributor

I don't think is necessary to take an screenshot or even test this situation here:
//cypress-visual-screenshots/baseline/Button.cy.tsx-secondary-button-with-both-icons.png

Screenshot 2023-10-18 at 17 10 40

We don't have or use it in real. There's no case of a button without label and two icons. 🤔

@pivilartisant pivilartisant force-pushed the button-test branch 2 times, most recently from 6b20a5c to c165301 Compare November 6, 2023 15:02
Copy link
Contributor

@mazmassa mazmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor details to fix but LGTM!

cypress/component/integration/Button.cy.tsx Outdated Show resolved Hide resolved
cypress/component/integration/Button.cy.tsx Outdated Show resolved Hide resolved
cypress/component/integration/Button.cy.tsx Outdated Show resolved Hide resolved
cypress/component/integration/Button.cy.tsx Outdated Show resolved Hide resolved
cypress/component/integration/Button.cy.tsx Outdated Show resolved Hide resolved
cypress/component/integration/Button.cy.tsx Outdated Show resolved Hide resolved
cypress/component/integration/Button.cy.tsx Outdated Show resolved Hide resolved
@pivilartisant pivilartisant merged commit 3115821 into main Nov 7, 2023
@pivilartisant pivilartisant deleted the button-test branch November 7, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants