Skip to content

Commit

Permalink
Add id attribute to dropdown button for improved accessibility (#487)
Browse files Browse the repository at this point in the history
* Add id attribute to dropdown button for improved accessibility

* Update upload-artifact action to version 3 in CI workflow

* Update package-lock.json to remove deprecated dependencies and update versions
  • Loading branch information
Ben-Rey authored Oct 10, 2024
1 parent a0e21cf commit 8eefe89
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 62 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
VITE_CI_TEST: true
- name: Upload Artifacts
if: always()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: test-results-${{ matrix.node-version }}
path: |
Expand Down
70 changes: 9 additions & 61 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/components/Dropdown/Dropdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export function Dropdown(props: DropdownProps) {
{...rest}
>
<button
id="dropdownUiKitButton"
data-testid="dropdown-button"
onClick={toggleDropdown}
type="button"
Expand Down

0 comments on commit 8eefe89

Please sign in to comment.