draft smart contract #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjah
reviewed
Jul 9, 2024
Ben-Rey
reviewed
Jul 11, 2024
Thykof
commented
Jul 11, 2024
| tolerance = 10; | ||
| } | ||
| // @ts-ignore | ||
| // TODO: check overflow ? (or use safeMath) |
| Context.currentThread(), | ||
| 40000000, // TODO: calibrate max gas | ||
| 0, | ||
| 0, // TODO: calibrate coins depending on the presence of the recipient balance in the token storage |
There was a problem hiding this comment.
we will do it with massalabs/massa-standards#162
|
I think one missing thing is to get schedueles by recipient (will be usefull for admin dashboard). |
Thykof
commented
Jul 16, 2024
Ben-Rey
reviewed
Jul 18, 2024
| amount, | ||
| interval, | ||
| occurrences, | ||
| occurrences, |
There was a problem hiding this comment.
at the creation, it's the same value for remaining
Ben-Rey
reviewed
Jul 18, 2024
| // Autonomous smart contract feature | ||
|
|
||
| // The function asyncSendFT will be trigger by autonomous smart contract feature. | ||
| export function asyncSendFT(schedule: Schedule): void { |
There was a problem hiding this comment.
Should we check that only this contract can call this function? It is exported in main so it callable by anyone.
There was a problem hiding this comment.
yes, I'll push in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.