Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework on Thyra HomePage and plugin Manager Page #583

Merged
merged 24 commits into from
Apr 5, 2023
Merged

Rework on Thyra HomePage and plugin Manager Page #583

merged 24 commits into from
Apr 5, 2023

Conversation

0xMazout
Copy link
Contributor

No description provided.

@0xMazout 0xMazout linked an issue Mar 31, 2023 that may be closed by this pull request
Rework HomePage And Plugin Manager Page card #569
Closed
4 tasks
@0xMazout 0xMazout changed the title re-align card Rework on Thyra HomePage and plugin Manager Page Mar 31, 2023
@0xMazout 0xMazout force-pushed the 569-rework-homepage-and-plugin-manager-page-card branch from 4584a2b to b2723c4 Compare March 31, 2023 17:03
@0xMazout
Copy link
Contributor Author

Considering i cannot test the linux and mac os aprt of the installation . If some one can make some tests on it por favor :)

@SlnPons
Copy link
Contributor

SlnPons commented Mar 31, 2023

Hey fyi - from I can see from your branch, we still have some problems:
HOME PAGE:

  • elements aren't aligned

image

* the "+ manage plugin" needs to be "manage pluginS" : spelling mistake * the toggle is different from 1 page to another:

image

image

PLUGIN MANAGER PAGE:

  • "install a plugin" bloc should be in not installed
  • the loader needs to stop loading at some point, it looks buggy otherwise.
  • there is no thyra logo at the top. We need one

Maybe I don't have the latest version. If the comment above are already managed, please ignored ;)
no need to answer, just wanted to save you some times with back and forth

@0xMazout
Copy link
Contributor Author

0xMazout commented Apr 3, 2023

I don't think you are on the good branch , because all of this stuff are solved

@0xMazout 0xMazout force-pushed the 569-rework-homepage-and-plugin-manager-page-card branch from b2723c4 to 4a06ab8 Compare April 3, 2023 08:17
ASAPSegfault
ASAPSegfault suggested changes Apr 3, 2023
View reviewed changes
web/home/src/components/pluginCard.tsx Outdated Show resolved Hide resolved
web/home/src/index.css Show resolved Hide resolved
web/home/src/pages/Home/home.tsx Outdated Show resolved Hide resolved
web/home/src/pages/Home/home.tsx Outdated Show resolved Hide resolved
web/plugin-manager/src/components/pluginBlock.tsx Outdated Show resolved Hide resolved
web/shared/styles/grid.ts Outdated Show resolved Hide resolved
mazmassa
mazmassa reviewed Apr 3, 2023
View reviewed changes
web/home/src/components/pluginCard.tsx Outdated Show resolved Hide resolved
web/plugin-manager/src/components/Header.tsx Outdated Show resolved Hide resolved
web/plugin-manager/src/components/pluginBlock.tsx Outdated Show resolved Hide resolved
web/plugin-manager/src/components/pluginBlock.tsx Show resolved Hide resolved
web/plugin-manager/src/components/pluginBlock.tsx Show resolved Hide resolved
web/plugin-manager/src/components/pluginBlock.tsx Show resolved Hide resolved
web/plugin-manager/src/pages/Manager.tsx Outdated Show resolved Hide resolved
web/plugin-manager/src/services/getOs.ts Outdated Show resolved Hide resolved
web/shared/styles/grid.ts Outdated Show resolved Hide resolved
web/home/src/pages/Home/home.tsx Show resolved Hide resolved
Pierregvx and others added 21 commits April 3, 2023 18:20
@Pierregvx
567 windows 11 installer not working (#584)
2f15c19 
* Update installer.py

added try / catch in case there is a problem with the decoding

* Update installer.py

cleant code

* testing build

* Update build.yml

* Update build.yml

put back conditions for the build
@Thykof
Remove old plugin manager (#490)
da0ea6d 
* clean code

* remove old plugin manager

* remove legacy api route mgmt_plugin

* remove unused files

* add comment on legacy code
@peterjah
add plugin quit channel (#587)
437a5d7 
* add plugin quit channel

* lint

---------

Co-authored-by: 0xMazout <[email protected]>
@0xMazout
re-align card
2473080
@0xMazout
Update Css problems and Fetch fake plugins
91119bf
@0xMazout
Mobile compatible ;)
10cf0b7
@0xMazout
Responsive homepage
3deb159
@0xMazout
delete fake plugins
1d30271
@0xMazout
Rework homepage
dd1c690
@0xMazout
Del Fake plugins
c855aef
@0xMazout
Update UI
4c00bd0
@0xMazout
Update title link
4818ab7
@0xMazout
Change the - to _ in the return of API .
30af382 
Because in ECMA Script you cannot define a variable with - in it.
@0xMazout
Revert "Change the - to _ in the return of API ."
4b2d6f1 
This reverts commit 16b077b.
@0xMazout
Update install block and focus on Plugin Store
0e40d9d
@0xMazout
prettier
01231d5
@0xMazout
prettier
472c26a
@0xMazout
Adding Bar loader
cabdf9a
@0xMazout
prettier
f6d8409
@0xMazout
Update to get pluginUrl related to the os
d389a14
@0xMazout
Clean Commentary
4590f57
@peterjah peterjah merged commit c0c1b00 into main Apr 5, 2023
@peterjah peterjah deleted the 569-rework-homepage-and-plugin-manager-page-card branch April 5, 2023 10:10
@Thykof Thykof mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASAPSegfault ASAPSegfault ASAPSegfault approved these changes

@mazmassa mazmassa mazmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework HomePage And Plugin Manager Page card
7 participants
@0xMazout @SlnPons @ASAPSegfault @mazmassa @peterjah @Pierregvx @Thykof