Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deploysc coins field empty causing panic and fix gas estimation issue #1375

Merged
merged 11 commits into from
Jan 13, 2025

Conversation

fleandrei
Copy link
Collaborator

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@fleandrei fleandrei added the bugfix bugfix PR label Jan 10, 2025
@fleandrei fleandrei self-assigned this Jan 10, 2025
@fleandrei fleandrei requested review from peterjah and Ben-Rey January 10, 2025 19:26
@fleandrei fleandrei changed the title fix deploysc coins field empty causing panic and enhance error use fix deploysc coins field empty causing panic and fix gas estimation issue Jan 13, 2025
@fleandrei fleandrei merged commit 642cae7 into main Jan 13, 2025
15 checks passed
@fleandrei fleandrei deleted the fix_deploysc_coin_field branch January 13, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix bugfix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants