Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

819 3 retrocompatibility allow edit fees #832

Merged
merged 4 commits into from
Nov 8, 2023
Merged

819 3 retrocompatibility allow edit fees #832

merged 4 commits into from
Nov 8, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Nov 7, 2023

No description provided.

@Thykof Thykof changed the base branch from main to 819-2 November 7, 2023 17:06
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (17d7f7c) 54.33% compared to head (22624b8) 54.29%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   54.33%   54.29%   -0.04%     
==========================================
  Files          41       41              
  Lines        2343     2341       -2     
==========================================
- Hits         1273     1271       -2     
  Misses        896      896              
  Partials      174      174
Files Coverage Δ
internal/handler/wallet/sign.go 55.47% <70.00%> (-0.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof marked this pull request as draft November 7, 2023 17:12
pivilartisant
pivilartisant approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@pivilartisant pivilartisant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peterjah
peterjah approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@peterjah peterjah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personnaly i would prefer not merge this and keep the breaking change.
I see no use case where dapp would forbid the fee edition.

Base automatically changed from 819-2 to main November 8, 2023 14:21
@Thykof Thykof marked this pull request as ready for review November 8, 2023 14:24
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thykof Thykof merged commit 11994a0 into main Nov 8, 2023
19 of 20 checks passed
@Thykof Thykof deleted the 819-3 branch November 8, 2023 15:31
@Thykof Thykof mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivilartisant pivilartisant pivilartisant approved these changes

@thomas-senechal thomas-senechal thomas-senechal approved these changes

@peterjah peterjah peterjah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thykof @peterjah @thomas-senechal @pivilartisant