Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

819-2: edit fees #827

Merged
merged 4 commits into from
Nov 8, 2023
Merged

819-2: edit fees #827

merged 4 commits into from
Nov 8, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Nov 6, 2023

This PR allow the user to modify the fees while signing an operation in the wails prompt.

TODO:

  • modify the fees
  • update the endpoint to return the modified operation

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (812747a) 53.97% compared to head (e577fa1) 54.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   53.97%   54.33%   +0.35%     
==========================================
  Files          40       41       +1     
  Lines        2314     2343      +29     
==========================================
+ Hits         1249     1273      +24     
- Misses        892      896       +4     
- Partials      173      174       +1     
Files Coverage Δ
pkg/types/public_key.go 30.23% <100.00%> (+3.40%) ⬆️
pkg/utils/errors.go 0.00% <ø> (ø)
pkg/wallet/account/testUtils.go 100.00% <100.00%> (ø)
internal/handler/wallet/rolls.go 68.96% <50.00%> (ø)
internal/handler/wallet/sign_message.go 55.73% <0.00%> (ø)
internal/handler/wallet/transfer.go 66.23% <0.00%> (ø)
pkg/wallet/account/account.go 60.81% <0.00%> (-1.46%) ⬇️
internal/handler/wallet/sign.go 55.79% <63.41%> (+1.80%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from 819 to main November 8, 2023 13:16
@Thykof Thykof marked this pull request as ready for review November 8, 2023 13:21
internal/handler/wallet/sign.go Outdated Show resolved Hide resolved
internal/handler/wallet/sign.go Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thykof Thykof merged commit 17d7f7c into main Nov 8, 2023
@Thykof Thykof deleted the 819-2 branch November 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants